Click here to Skip to main content
15,938,218 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
Error came in my SQL query

SELECT cstdetails.cstname, cstdetails.loannu, cstdetails.loanamt, cstdetails.mobile1, cstduebill.principal, cstduebill.dueint, cstduebill.billtotal, cstduebill.loandur, cstduebill.duedate, cstduebill.billdate, cstduebill.rectno,     cstdetails.loannu, left(duedate,2) from cstduebill where left(duedate,2) = '" + tstTxt.Text + "' inner join cstdetails on  cstduebill.loanslno = cstdetails.loannu


Incorrect syntax near the keyword 'inner'.
any one give me solution for my error.

What I have tried:

Error came in my SQL query 
Posted
Updated 30-Dec-22 6:00am
Comments
0x01AA 30-Dec-22 11:48am    
Have a look to your SQL statement e.g. here: https://codebeautify.org/sqlformatter[^]

A join can only be placed immediately after 'FROM'. Therefore this 'can' be youre solution:

from
cstduebill
inner join cstdetails on cstduebill.loanslno = cstdetails.loannu
where
left(duedate, 2) = '" + tstTxt.Text + "'


And be aware of SQL injection when using user inputs directly as part of your SQL ;)
Boopalslm 30-Dec-22 12:04pm    
It is working fine. Thanks a lot.
0x01AA 30-Dec-22 12:06pm    
You are welcome. Makes sense you accept Solution 1 ;)

1 solution

To add to what 0x01AA has said ...
Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900