index out of range exeption?

Question

0.00/5 (No votes)

See more:

VS2012

i've got an index out of range exeption on this one

VB

If My.Settings.SavedLinks IsNot Nothing Then
            For Each Sl As String In My.Settings.SavedLinks
                Dim LinkInfo As String = Sl.Split(",").ToString
                Dim NewLink As New ToolStripButton(LinkInfo(0))
                ToolStrip1.Items.Add(NewLink)
                NewLink.Tag = LinkInfo(1)'it gives the error here
                AddHandler NewLink.Click, AddressOf GoToLink
                Dim sep As New ToolStripSeparator
                ToolStrip1.Items.Add(sep)
            Next
        End If

i dont know what im doing wrong but when it loads it give the error

ps
its for a favorite bar in my webbrowser

Posted 27-Jan-13 3:38am

Bart de Lange

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andreas Gieriet · Answer 1 · 2013-01-27T03:52:00

Solution 2

Use the debugger:
1) set to stop on throwing exception (Debug --> Exceptions --> .Net Exceptions --> throwing [x])
2) run the program in debug mode
3) when the debugger stops where the execption is thrown, check the message and inspect the individual variables
Cheers
andi

Posted 27-Jan-13 3:52am

Andreas Gieriet

Updated 27-Jan-13 3:54am

v2

OriginalGriff · Answer 2 · 2013-01-27T03:48:00

Solution 1

One of your strings does not contain a ',' character. As a result, there is only one entry in the LinkInfo array, and when you try to access the second one it throws an exception.
Put a breakpoint on the line that throws the error, and look at the value in S1.

Posted 27-Jan-13 3:48am

OriginalGriff

Comments

Bart de Lange 27-Jan-13 10:13am

no it does not contain any string in my.settings.savedlinks but it gives the error

Bart de Lange 27-Jan-13 10:17am

and how do i put a breakpoint to a line??

OriginalGriff 27-Jan-13 10:35am

Easiest way is to put the cursor on the line, then go to the menu: "Debug...Toggle Breakpoint" (it will also show you a short cut key, probably F9). If you click it, it will put a red dot to the left of the line. to show where the breakpoint is. In future, you can just click where the red dot appears to add a breakpoint to that line (now that you know where it is!)

If your settings.SaveLinks contains no strings, then it wouldn't get to the error point, so it contains at least one string - which may be the empty string, just as a "place holder".
If you add a test as the first thing you do in the loop:
If Not String.IsNullOrWhiteSpace(S1) Then
...
End If
Then that would help, as would checking the size of the array before you use it at all:
Dim LinkInfo As String = Sl.Split(",").ToString
If LinkInfo.Length >= 2 Then
...
End If

Bart de Lange 27-Jan-13 10:42am

thanks it works

OriginalGriff 27-Jan-13 11:11am

You're welcome!