Creating 2d string array dynamically

Question

1.00/5 (1 vote)

See more:

the below code there is no issue,
but address not able to get.
please provide your solution.
i have below code

C#

#include<iostream.h>
#include<stdlib.h>
void main()
{
    char **array;
    int row,column;
    char temp='A';
    cout<<"enter the Row"<<endl;
    cin>>row;
    cout<<"enter the Column"<<endl;
    cin>>column;
    array=(char **)malloc(row*sizeof(char *));
    for (int i=0;i<row;i++) {
        array[i]=(char*)malloc(column*sizeof(char));
    }

    for(int j=0;j<row;j++)  {
        for (int k=0;k<column;k++)
        {
            cout<<&array[j][k]<<endl;
            array[j][k]=temp;
            cout<<*(*(array+j)+k)<<endl;
            temp++;
        }
    }
}

[edit]Code block added - OriginalGriff[/edit]

Posted 3-Feb-13 1:51am

ashu_1july

Updated 3-Feb-13 2:01am

OriginalGriff

v4

Add a Solution

Comments

ashu_1july 3-Feb-13 10:27am

the above question i want to allocate memeory for 2d array string but not able to do.
where is the wrong please help me.

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matthew Faithfull · Answer 1 · 2013-02-03T06:59:00

You seem to have allocated a 2D array of char instead of a 2D array of strings. However this may or may not be what you intended. You've tagged the question as C++ but seem to be writing 'C'. A more C++ way of doing this might include amongst other lines:-

#include <vector>

using namespace std;

vector< vector< string > > ArrayOfArrayOfStrings;
vector< string > FirstArrayOfStrings;
FirstArrayOfStrings.push_back( string("A") );

ArrayOfArrayOfString.push_back( FirstArrayOfStrings );

The good part is all the mallocing gets done for you along with all the freeing so your program doesn't leek memory and there are no more hard coded fixed limits or 'magic' numbers in your code.
The down side is you will need to put in some hours to understand and use iterators to do the outputting of the vector properly.

__UFNHGGI_H__ · Answer 2 · 2013-02-03T23:34:00

C++

#include <string>
#include <iostream>

int main(int _argc, char* _argv[])
{
    int nX, nY;
    std::cin >> nX;
    std::cin >> nY;

    //create array
    std::string** strArray;
    strArray = new std::string*[nX];
    for(int i = 0; i < nX; i++)
        strArray[i] = new std::string[nY];

    strArray[0][0] = "Hello";
    strArray[nX-1][nY-1] = "World";

    //delete array
    for(int i = 0;  i < nX; i++)
        delete strArray[i];
    delete strArray;
}

Creating 2d string array dynamically

2 solutions

Solution 2

Solution 3

Add your solution here

Preview 0

Creating 2d string array dynamically

2 solutions

Solution 2

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us