Click here to Skip to main content
12,630,420 members (32,595 online)
Rate this:
 
Please Sign up or sign in to vote.
See more: SQL-server-2005 SQL-Server , +
is this efficient way of writing the stored procedure in a loop??

for (int i = 0; i < purchaseListView.Items.Count; i++)
                     {
Connection con = new Connection();
                     SqlCommand cmd = new SqlCommand();
                     SqlCommand cmdFifo = new SqlCommand();
                     con.OpenConnection();
                     cmd.Connection = con.DataBaseConnection;
                     cmd.CommandType = CommandType.StoredProcedure;
                     cmd.CommandText = "insertDetail";
                     cmdFifo.Connection = con.DataBaseConnection;
                     cmdFifo.CommandType = CommandType.StoredProcedure;
                     cmdFifo.CommandText = "insertInToMain";
please let me know the right way of looping the stored procedure
best regards
bunzitop
Posted 15-Mar-13 6:14am
bunzitop1.2K
Updated 15-Mar-13 6:38am
v2

1 solution

Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 1

No, because you open the connection again and again and again. Outside your loop, open the connection.
  Permalink  
Comments
bunzitop 15-Mar-13 11:47am
   
suppose i kept the connection outside loop, then will it be standard form of codding and efficient way of coding ??? will my code perform high??
ryanb31 15-Mar-13 11:51am
   
For the most part. You can also move the creation of the Command object out and then just clear and readd parameters inside the loop. You might also want to look into using the keyword "using".
Sergey Alexandrovich Kryukov 15-Mar-13 15:04pm
   
Good point, a 5.
—SA

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month


Advertise | Privacy | Mobile
Web02 | 2.8.161205.3 | Last Updated 15 Mar 2013
Copyright © CodeProject, 1999-2016
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100