How to Loop through value sof Table under SP

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

Hi I have an requirement where i need to loop through the values of one table to another while updating pleas find any soln..

SQL

SET @Rid=(SELECT ID FROM RIGHTS WHERE RoleId=@RoleId)

If i am getting a values of Rid as
Rid
====
2
4
6
7

Now i need to pass all theses four values in a loop to update the another table with an id values as 2 4 6 & 7. I hope my requirement is clear

Posted 26-Mar-13 20:52pm

sahmed4

Add a Solution

Comments

gvprabu 27-Mar-13 3:17am

Hi, Ur Question is not clear....
In 2nd table what based u need to Update @RID value...

Use UPDATE Statement Directly... like as follows

UPDATE M SET M.RID=R.RID
FROM Main_Table M
INNER JOIN RIGHTS R ON R.RoleId=M.RoleID

sahmed4 27-Mar-13 3:30am

Hi.
while Inserting values into table Rights i am getting the Current Auto increment value but how do i do this for update sp if i have @Roles values="1,3,5,7,8," that will insert in as 1 3 5 7 8 individually in all the newly created rows in rights table but while updating how do handle this
This is my Insert Sp
====================
ALTER PROC [C244570_hrms12].[h_AddRole]
(
@RoleName NVARCHAR(MAX),
@Roles NVARCHAR(MAX)
)
AS
DECLARE @RoleID INT,@StartingPos INT,@RecPos INT,@RightId INT
DECLARE @RecSet VARCHAR(500)
BEGIN
INSERT INTO ROLES(RoleName) VALUES(@RoleName)
SET @StartingPos=1
SET @RoleId=(SELECT IDENT_CURRENT('ROLES'))
WHILE @StartingPos<=LEN(@roles)
BEGIN
SELECT @RecPos=CHARINDEX(',',@roles,@StartingPos)
SELECT @RecSet=SUBSTRING(@roles,@StartingPos,@Recpos-@StartingPos)
SET @RightId=@RecSet
INSERT INTO Rights(RightId,RoleId)VALUES(@RightId,@roleId)
SELECT @StartingPos=@RecPos+1
END
END

this is my Update SP
====================
ALTER PROC [C244570_hrms12].[h_UpdateRole]
(
@Id INT,
@RoleName NVARCHAR(MAX),
@Roles NVARCHAR(MAX)
)
AS
DECLARE @RoleId INT,@StartingPos INT,@RecPos INT,@RightId INT
DECLARE @RecSet VARCHAR(500),@Rid NVARCHAR(50)
BEGIN
UPDATE Roles SET RoleName=@RoleName WHERE Id=@Id
SET @StartingPos=1
SET @Rid=(SELECT ID FROM RIGHTS WHERE RoleId=@RoleId)
WHILE @StartingPos<=LEN(@roles)
BEGIN
SELECT @RecPos=CHARINDEX(',',@roles,@StartingPos)
SELECT @RecSet=SUBSTRING(@roles,@StartingPos,@RecPos-@StartingPos)
SET @RightId=@RecSet
UPDATE Rights SET RightId=@RightId,RoleId=@RoleId WHERE Id=@Rid
ENDs
END

gvprabu 27-Mar-13 3:41am

Give some sample Data ur table Structure... and
in Update SP how u will get @RoleId values, nowhere u assigned any value for this variable.

sahmed4 27-Mar-13 4:20am

Please find out this link
http://www.codeproject.com/Questions/568241/ErrorplusinplusUpdatingplustheplusSppluswithplussp
specified my problem in elaborately...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Answer 1 · 2013-03-27T12:32:00

sahmed4 wrote:
if i have @Roles values="1,3,5,7,8," that will insert in as 1 3 5 7 8 individually in all the newly created rows in rights table but while updating how do handle this

Have a look at this example:

SQL

DECLARE @sRoles NVARCHAR(100)
DECLARE @roles TABLE([Roles] NVARCHAR(100))

SET @sRoles = '1,3,5,7,8,'

INSERT INTO @roles ([Roles])
VALUES (@sRoles)

SELECT *
FROM @roles

;WITH SplitedString AS
(
		SELECT LEFT([Roles],CHARINDEX(',',[Roles])-1) AS [Role], RIGHT([Roles],LEN([Roles])-CHARINDEX(',',[Roles])) AS Remainder
        FROM @roles
        WHERE [Roles] IS NOT NULL AND CHARINDEX(',',[Roles])>0
    UNION ALL
    SELECT LEFT(Remainder,CHARINDEX(',',Remainder)-1), RIGHT(Remainder,LEN(Remainder)-CHARINDEX(',',Remainder))
        FROM SplitedString
        WHERE Remainder IS NOT NULL AND CHARINDEX(',',Remainder)>0
    UNION ALL
    SELECT Remainder, NULL
        FROM SplitedString
        WHERE Remainder IS NOT NULL AND CHARINDEX(',',Remainder)=0
)
SELECT *
FROM SplitedString
WHERE [Role]!=''
ORDER BY [Role]

Result:

Role    Remainder
1	3,5,7,8,
3	5,7,8,
5	7,8,
7	8,
8

To update your table, you shold use something like this:

SQL

INSERT INTO TableName (Column1)
SELECT *
FROM SplitedString
WHERE [Role]!=''
ORDER BY [Role]