File Bigger when uploading on ftp server

Question

4.00/5 (1 vote)

See more:

I want to upload a file to a ftp server from my application.
But when upload completes, the file uploaded is bigger than the original one
I have discovered that if I have of buffer of 1024 bytes and on the last turn only 512 are occupied, it also writes the rest "0" 512 bytes to the file

Here is my code:

C#

public bool UploadArticol(String adresaserver,String numefisier)
        {
            try
            {
                FileInfo toupload = new FileInfo("articles\\"+numefisier+".dat");
                FtpWebRequest request = (FtpWebRequest)WebRequest.Create("ftp://"+adresaserver+"/" + toupload.Name);
                request.Method = WebRequestMethods.Ftp.UploadFile;
                request.Credentials = new NetworkCredential("lucian", "lucian");
                Stream ftpstream = request.GetRequestStream();
                FileStream file = File.OpenRead("articles\\"+numefisier+".dat");
                int length = 1048576;
                byte[] buffer = new byte[length];
                int bytesread = 0;
                do
                {
                    bytesread = file.Read(buffer, 0, length);
                    ftpstream.Write(buffer, 0, length);
                }
                while (bytesread != 0);
                file.Flush();
                file.Close();
                ftpstream.Close();
               Console.WriteLine("Upload complete");
               
            }
            catch (Exception ee)
            {
               Console.WriteLine(ee.Message);
               return false;
            }
            return true;
        }

Posted 5-Apr-13 2:43am

Luci C

Add a Solution

2 solutions

Solution 1

you may need to use Flush() method on stream object as well...
if you have still issues, refer these links..
http://www.digitalcoding.com/Code-Snippets/C-Sharp/C-Code-Snippet-Upload-file-to-FTP-Server.html[^]
http://blog.pbdesk.com/2009/03/uploading-files-to-ftp-server-using.html[^]

Posted 5-Apr-13 3:00am

Naz_Firdouse

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matt T Heffron · Accepted Answer · 2013-04-05T06:54:00

You are always writing the data in blocks of 1048576 bytes no matter how many are actually read.
Two choices:
1. Change the Write() to be:

C#

ftpstream.Write(buffer, 0, bytesread);

2. Just have the two streams deal with each other directly:

C#

public bool UploadArticol(String adresaserver, String numefisier)
{
  string uploadname = "articles\\"+numefisier+".dat";
  try
  {
    FileInfo toupload = new FileInfo(uploadname);
    FtpWebRequest request = (FtpWebRequest)WebRequest.Create("ftp://"+adresaserver+"/" + toupload.Name);
    request.Method = WebRequestMethods.Ftp.UploadFile;
    request.Credentials = new NetworkCredential("lucian", "lucian");
    Stream ftpstream = request.GetRequestStream();
    using (FileStream file = File.OpenRead(uploadname))
    {
      file.CopyTo(ftpstream);
    }
    Console.WriteLine("Upload complete");
  }
  catch (Exception ee)
  {
    Console.WriteLine(ee.Message);
    return false;
  }
  return true;
}