Datagrid Converting String to Int

Question

1.00/5 (1 vote)

See more:

When i add up shakes entrees and barsfor each row now..ex. 12 + 12+ 12 the toal comes to 121212

VB

myTable.Columns.Add("Shake /Cereal", GetType(String))
        myTable.Columns.Add("Entrees", GetType(String))
        myTable.Columns.Add("Bars", GetType(String))
        myTable.Columns.Add("Total", GetType(String))
        myTable.Columns("Total").Expression = "[Shake /Cereal] + Entrees + Bars"

VB

Select Case e.ColumnIndex
           Case 5 To 7
               Dim myVal As Integer = 0
               Dim result As Boolean = Int32.TryParse(DataGridView1.Rows(e.RowIndex).Cells(e.ColumnIndex).Value, myVal)
               If Not result Then
                   MessageBox.Show("Please enter a numeric value.", "Input Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
                   DataGridView1.Rows(e.RowIndex).Cells(e.ColumnIndex).Value = String.Empty
               Else
                   'proper value! use myVal
               End If
           Case Else
       End Select

Posted 21-Aug-13 5:40am

PythonProgrammer

Updated 22-Aug-13 0:50am

v2

Add a Solution

Comments

TryAndSucceed 21-Aug-13 12:12pm

Are you defining the column index somewhere? Coz you are looking for 5,6,7 where I see only 0,1,2,3.

PythonProgrammer 21-Aug-13 12:15pm

i have more columns before the ones that are above

TryAndSucceed 21-Aug-13 14:16pm

While debugging, is it entering your if/else statement?

Maciej Los 21-Aug-13 15:07pm

Instead If... ElseIf.. End use Select... Case ... End.

PythonProgrammer 21-Aug-13 15:10pm

tried that dim and for and datagrid cannot go between select and case

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2013-08-21T21:15:00

OK, before i answer the question, few notes:
1) bad practice - if some part of code is used more than once, you need to move it into separate procedure or function

VB

If (e.ColumnIndex = 5) Then   ' Checking numeric value for Column 5 only
        'see code below
ElseIf (e.ColumnIndex = 6) Then   ' Checking numeric value for Column 6 only
        'see code below
ElseIf (e.ColumnIndex = 7) Then   ' Checking numeric value for Column 7 only
    'code which was used 2 times before
    '<-- start
    Dim value As String = DataGridView1.Rows(e.RowIndex).Cells(e.ColumnIndex).Value.ToString()
    For Each c As Char In value
        If Not Char.IsDigit(c) Then
            MessageBox.Show("Please enter a numeric value.", "Input Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
            DataGridView1.Rows(e.RowIndex).Cells(e.ColumnIndex).Value = String.Empty
            Exit Sub
        End If
'end -->
End if

2) bad practice - if you want to check value in a range of columns, use:

VB

If (e.ColumnIndex=5) Or (e.ColumnIndex=6) Or (e.ColumnIndex=7) Then
'...do something...
Else
'...do something...
End If

or

VB

 Select Case e.ColumnIndex
    Case 5, 6, 7
    '...do something...
    Case Else
    '...do something...
End Select

Select Case .... End Select[^]

3) bad practice - if you want to check if value is numeric, do not convert it into string and do not check it sign by sign, but please use Convert.To<TypeOfData>[^] or <TypeOfData>.Parse[^] or <TypeOfData>.TryParse[^] method
More about Parsing Numeric Strings[^]

Finally, the answer is: using TryParse method replace wrong input into numeric value (for example to 0 /zero/) ;)

[EDIT]

VB

Private Sub DataGridView1_CellEndEdit(ByVal sender As System.Object, ByVal e As System.Windows.Forms.DataGridViewCellEventArgs) Handles DataGridView1.CellEndEdit

Select Case e.ColumnIndex
    Case 5 to 7
        Dim myVal AS Integer = 0
        Dim result As Boolean = Int32.TryParse(DataGridView1.Rows(e.RowIndex).Cells(e.ColumnIndex).Value,myVal)
        If not result Then 
             'convertion failed
        Else
             'proper value! use myVal
        End If
    Case else
        'do nothing
End Select

End Sub

[/EDIT]

PythonProgrammer · Accepted Answer · 2013-08-22T02:58:00

VB

Private Sub DataGridView1_DataError(sender As Object, e As System.Windows.Forms.DataGridViewDataErrorEventArgs) Handles DataGridView1.DataError

       If MessageBox.Show("Please enter a numeric value only.", "Input Error", MessageBoxButtons.OK, MessageBoxIcon.Error) Then
           e.Cancel = True
       End If

   End Sub

Datagrid Converting String to Int

2 solutions

Solution 1

Solution 3

Add your solution here

Preview 0