Switch statement with if else if. DevC++

Question

0.00/5 (No votes)

See more:

I have been working on a grade system but I am not sure whats wrong with the code.

C

#include <iostream>
#include <stdio.h>
#include <string>

using namespace std;

int main()
{
    int aCount = 0, bCount = 0, cCount = 0, fCount = 0;
    int name = 0;
    int name2 = 0;
    string one = "";

    printf("Enter your grade: ");

    scanf("%d",&name);

    if (name >=90) {
        // one = one + "A";
        name2 = 1;
    }
    else if (name >= 80) {
        // one = one + "B";
        name2 = 2;
    }
    else if (name >=70) {
        // one = one + "C";
        name2 = 3;
    }
    else if (name <=69) {
        // one = one + "F";
        name2 = 4;
    }

    //----------------------------------------------

    switch( name2 ) {
        case '1':
            ++aCount;
            break;
        case '2':
            ++bCount;
            break;
        case '3':
            ++cCount;
            break;
        case '4':
            ++fCount;
            break;
    }

    printf( "A: %d\n", aCount );

    printf( "B: %d\n", bCount );

    printf( "C: %d\n", cCount );

    printf( "F: %d\n", fCount );

    getchar();
    getchar();
    return 0;
}

the task of the above code is that is first asks for your grades number example: 90. then using the if else statement makes name2 variable to 1 if name is >= 90, 2 if name >= 80, 3 if name >= 70 and 4 if name <=69. After doing that it uses the switch case statement, to check if the variable called name2 is 1 or 2 or 3 or 4. After that its adds ++1 into counter and shows me the result. The problem currently is that it is not showing anything other then all values = 0.

I am not sure what exactly I am doing wrong here. Any examples would be great. :)

Posted 8-Sep-13 0:54am

Ammar_Ahmad

Updated 8-Sep-13 2:40am

phil.o

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

André Kraak · Accepted Answer · 2013-09-08T01:02:00

Solution 1

To solve your problem remove the '' from the case values.

C

switch( name2 ) {
    case 1:
        ++aCount;
        break;
    case 2:
        ++bCount;
        break;
    case 3:
        ++cCount;
        break;
    case 4:
        ++fCount;
    break;
}

May I suggest you merge the if- and switch-statement.

C

if (name >= 90)
{
    ++aCount;
}
else if (name >= 80)
{
    ++bCount;
}
else if (name >= 70)
{
    ++cCount;
}
else if (name <= 69)
{
    ++fCount;
}

Posted 8-Sep-13 1:02am

André Kraak

Updated 8-Sep-13 1:06am

v2

Comments

Ammar_Ahmad 8-Sep-13 7:10am

That didn't work D:
But Ive found something interesting.

scanf("%d",&name);

if (name >=90)
{
// one = one + "A";
name2 = 1;
}
else if (name >= 80)
{
// one = one + "B";
name2 = 2;
}
else if (name >=70)
{
// one = one + "C";
name2 = 3;
}
else if (name <=69)
{
// one = one + "F";
name2 = 4;
}
printf("%d", &name2);

putting printf("%d", &name2); and giving it any input gives me a value: 2293576. Not sure why it is not giving that. When it should be giving me 1 or 2 or 3 or 4 in that variable.

André Kraak 8-Sep-13 7:20am

2293576 is the pointer value, because you are using '&name2'.
Use 'name2' without '&' instead.

Ammar_Ahmad 8-Sep-13 7:37am

Actually that worked :D thanks for the tip. Too bad they don't teach these sort of stuff in school D:

Here is the code in case anyone else wanted to do this:

#include <iostream>
#include <stdio.h>
#include <string>

using namespace std;

int main()
{
int aCount = 0, bCount = 0, cCount = 0, fCount = 0;
int name = 0;
int name2 = 0;
string one = "";

printf("Enter your grade: ");

scanf("%d",&name);

if (name >=90)
{
// one = one + "A";
name2 = 1;
switch( name2 ) {
case 1:
++aCount;
break;
}
}
else if (name >= 80)
{
// one = one + "B";
name2 = 2;
switch( name2 ) {

case 2:
++bCount;
break;
}
}
else if (name >=70)
{
name2 = 3;

// one = one + "C";
switch( name2 ) {
case 3:
++cCount;
break;
}
}
else if (name <=69)
{
name2 = 4;

switch( name2 ) {
case 4:
++fCount;
break;
// one = one + "F";
}

}
printf("%d", name2);

//----------------------------------------------

printf( "A: %d\n", aCount );

printf( "B: %d\n", bCount );

printf( "C: %d\n", cCount );

printf( "F: %d\n", fCount );

getchar();
getchar();
return 0;

}

Ammar_Ahmad 8-Sep-13 7:28am

I have done it using if else if before but I am required to do this using the case switch. Which I am unable to understand how to do.. Any suggestion on how to use it in switch case would be great.