why winForm slow down

Question

1.00/5 (1 vote)

See more:

I have develop winForm application
using
1. vs 2012
2. Sqlserver 2012
3. Devcomp
4. 3 tier architecture
The execution of program were fine but by the time i did more work on my application it's starting time going down and down and down Now it take too much time to start/execute.. and specially show an error timeout in my sql DAL class when i use this code on one of my form. why my winform slow down now?

C#

if (clbBooksName.GetItemChecked(0) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 1";
           }
           if (clbBooksName.GetItemChecked(1) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 2";
           }
           if (clbBooksName.GetItemChecked(2) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 3";
           }
           if (clbBooksName.GetItemChecked(3) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 4";
           }
           if (clbBooksName.GetItemChecked(4) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 5";
           }
           if (clbBooksName.GetItemChecked(5) == true)
           {
               BookSelection = "OR Hadith_Book_Number = 6";
           }
           foreach (DataGridViewRow Datarow in dataGridView1.Rows)
           {
               if (Datarow.Cells[0].Value != null && Datarow.Cells[1].Value != null && Datarow.Cells[2].Value != null && Datarow.Cells[3].Value != null)
               {
                   WhereClause += Datarow.Cells[0].Value.ToString() + "= 4";
               }
           }

           SearchQuery = "Select * From Hadiths_old Where Baab_Id < 100 =" + BookSelection + "AND" + WhereClause;
           MessageBox.Show(WhereClause);

Posted 27-Oct-13 19:59pm

Muhamad Faizan Khan

Updated 27-Oct-13 20:35pm

v3

Add a Solution

Comments

Sergey Alexandrovich Kryukov 28-Oct-13 2:07am

How can anyone possibly fix it for you? There can be too many ways to screw up performance... Do be serious...
—SA

Muhamad Faizan Khan 28-Oct-13 2:14am

what are some??

Sergey Alexandrovich Kryukov 28-Oct-13 3:14am

How can I know what could it be in your case?
You fragment of code is not related to performance problems but unacceptable anyway...
—SA

Muhamad Faizan Khan 28-Oct-13 3:28am

fragment of code unacceptable why??

Sergey Alexandrovich Kryukov 28-Oct-13 3:33am

Because you write 6 nearly identical fragment of code. The whole idea of programming is: D.R.Y.:
http://en.wikipedia.org/wiki/Don%27t_repeat_yourself.
And writing it normally is very easy. Also, you hard-code strings (again, almost identical) using immediate constant. How to explain that? This is not bad programming, this is not programming at all.
—SA

Muhamad Faizan Khan 28-Oct-13 3:56am

there is no alternate of that 6 line of code. Because of qurey formation depends upon checklistbox item selection. do you know any alternate?

Sergey Alexandrovich Kryukov 28-Oct-13 15:15pm

What do you mean "know"? Essentially, this is two-liner. 1) get index of selected item, 2) Assign BookSelection with parameter equals to this index: 1, 2, 3 (say, index+1)...
Then, I'm afraid to imagine what you are going to do with the string BookSelection. If you output anything to a string, you should not use this string as data, the only legitimate use of it should be showing it in the UI...
—SA

Muhamad Faizan Khan 29-Oct-13 0:34am

it is check list box. multiple check we can get!

Sergey Alexandrovich Kryukov 29-Oct-13 10:03am

Fist of all, if they are check boxes, they don't have to me mutually exclusive. So, you first assign "OR Hadith_Book_Number = 2" and, below, say, "OR Hadith_Book_Number = 5", with previous assignment lost, overwritten. Already the absurd.
You can use an array of radio buttons. This is not a place and not the code where we can discuss such elementary things. I mean, your problem is rooted well before this fragment of code. I would seriously advise you to step back and learn some programming in simpler projects, maybe console-only. Or I don't know...
—SA

Sergey Alexandrovich Kryukov 28-Oct-13 3:15am

Oh yes, "select *..." is something... The only problem is: it could be not the only problem...
—SA

thatraja 28-Oct-13 3:01am

Not enough details to spot your problem. Include more details

Muhamad Faizan Khan 28-Oct-13 3:10am

what more?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

dibyaaryan007 · Answer 1 · 2013-10-27T20:30:00

if you are retrieving any database records in application start.
then it ll slow down.
1st check connection is avail or not. if avail then retrieve value.
always use procedure and views to retrieve and insert record.
it makes performance faster.
don't retrieve all records mean to say never use "*" in queries.
always retrieve columns that you need. it makes application faster.

Hope these things help you ..

use column names. not "*"
Contact your Database administrator for help.
as its time out error thrown by sql server.
restart the server and try again.

Ibrahim Hebish · Answer 2 · 2013-10-27T20:40:00

win forms is less performance than MVC so try check if you can change it from ASP.net win forms to MVC

OR

you can check your code performance by using tools for performance test and enhance your code make less loops , check the connections between all servers SQL server and Application front end servers
it maybe a connection problem between server if certificate between servers expired (it will authenticate every time application server call SQL server it happens with me)

try to troubleshoot the problem with IT specialists who administer servers , and enhance your code blocks and it will work as charm and do not worry ^-^

why winForm slow down

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0