implementing a queue in C

Question

0.00/5 (No votes)

See more:

Ok so I'm trying to implement a queue in C but the whole use of pointers has f****d up my mind, seriously I cant seem to wrap my head around them, I just want to make sure I'm on the right track(which is suspect is not the case :( )

So if anyone could just make a quick check and point me in the right direction I'd be grateful.

here's my code so far:

C#

#include "queue.h"
#include "string.h"

#define QUEUE_MAX_SIZE 10

static Person queue[QUEUE_MAX_SIZE];
static int head = 0, tail = 0, nbr_elem = 0;

typedef struct{
char firstName[20];
char surName[20];
char persNbr[20];
}Person;


void enqueue(Person *person)
{
    strcpy(char *queue[tail], *person.firstName);
    strcpy(char *queue[tail], *person.surName);
    strcpy(char *queue[tail], *person.persNbr);
}

void dequeue(Person *person)
{
    int i;

        for(i=0;i<queue.size;i++){
            if(queue[i]=head)
                 strcpy(person, queue[head]);
                 queue[head]=null;
        }

}

Posted 12-Nov-13 0:43am

nandushjkr

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

LaxmikantYadav · Answer 1 · 2013-11-12T00:50:00

Solution 1

http://cprogramsblog.blogspot.in/2012/11/c-program-to-implement-queue-operations.html[^]

Posted 12-Nov-13 0:50am

LaxmikantYadav

nv3 · Answer 2 · 2013-11-12T01:44:00

It's not the concept of pointers that is apparently bothering you, but the concept of structures. So don't worry, pointers are relatively easy to understand.

Let's start with your enqueue function:

C++

void enqueue(Person *person)
{
    strcpy(char *queue[tail], *person.firstName);
    strcpy(char *queue[tail], *person.surName);
    strcpy(char *queue[tail], *person.persNbr);
}

As person is a pointer to a Person object, all the members of that object are being addressed by person->membername. Your queue array contains elements of type Person. And hence queue[n] is a Person object. Hence, you refer to its members by queue[n].membername. The first line of your function should therefore be:

C++

strcpy (queue[tail].firstname, person->firstName);

Instead of referring to queue[tail] several times, you could equally well define a pointer to that Person object by saying

C++

void enqueue(Person *person)
{
    Person* p = &queue[tail];
    strcpy (p->firstname, person->firstName);
    ...

Doesn't that look better? Now one step further. Why do you want to copy the members of your Person structure one-by-one. Let the C compiler do that for you. As your members are all plain data (and no pointers to other objects) you could do the whole copying in a single line:

C++

void enqueue (Person *person)
{
    queue[tail] = *person;

And finally, you forgot one important thing: You should have incremented the tail index. So the next time you are entering a person it goes into the next cell of your array. And I guess you have envisioned the nbr_elem variable to hold the number of current queue elements. So you should increment that as well.

Your dequeue function is totally off track, as you might have noticed. The idea should be to do the copying in reverse, just this time take the queue cell with index head as the source. I am not going to provide the source code for that as it is a good exercise for you.

Also, you should do some checking for queue over- and underflow in both functions enqueue and dequeue.