Having problems with negative values!

Question

0.00/5 (No votes)

See more:

Ok, I created a class which manipulates with three values like following:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace Account
{
    public class Account
    {
        private double amount;
        private double drawing;
        private double deposit;
    
        public Account()
        {
        }

        public double Amount
/*This shows the amount or state of your account*/
        {
            get { return amount; }
            set { amount = value;}
        }
        
        public double Drawing
/*This presents the drawing amount form account*/
        {
            get { return drawing; }
            set { drawing = value; }
        }

        public double Deposit
/*This presents the deposit amount in account*/
        {
            get { return deposit; }
            set { deposit = value; }
        }        

    }
}

How to resolve the code to not allow drawing from account if the amount is less than drawing.
I can fix that in a form application, but if there are involved the classes I don't know how to call class methods and how to fix this inside the class.

Thank you in advance for your reply.

Posted 4-Dec-13 22:51pm

dr_iton

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-12-04T23:00:00

That's not really simple to describe, because the code you show doesn't include an code to reduce the balances, but it does allow direct subtraction from the account values.
What I would probably do is make the property setters private (or possibly protected) instead of public to prevent that, and create a Withdraw method instead - it can check and either throw an exception or return a status code which says "insufficent funds":

C#

/// <summary>
/// This shows the amount or state of your account
/// </summary>
public double Amount
    {
    get { return amount; }
    private set { amount = value; }
    }
/// <summary>
/// This presents the drawing amount form account
/// </summary>
public double Drawing
    {
    get { return drawing; }
    private set { drawing = value; }
    }
/// <summary>
/// This presents the deposit amount in account
/// </summary>
public double Deposit
    {
    get { return deposit; }
    private set { deposit = value; }
    }
/// <summary>
/// Take the money from the account
/// </summary>
/// <param name="withdrawl"></param>
/// <returns></returns>
public bool Withdraw(double withdrawl)
    {
    if (Amount < withdrawl) return false;
    Amount -= withdrawl;
    return true;
    }

phil.o · Answer 2 · 2013-12-04T22:55:00

Solution 1

Drawing and Deposit should be methods instead of properties.
An account basically holds a given amount of money; drawing from it or depositing to it are methods on the account; drawing from it should be allowed or not depending on the available amount.

Posted 4-Dec-13 22:55pm

phil.o