use of finally and returning value from function

Question

0.00/5 (No votes)

See more:

Hi,

I have code

C#

private string GetName()
        {
            string name = "";
            try
            {
                name = "This is my name";
                //throw new NotImplementedException();
                return "from try";
            }
            catch (Exception)
            {
                return "Error";
            }
            finally
            {
                name = "";//clears object memory.
            }
            return name;

        }

in this code if i want to return name string i can use return in the end of the function but when finally runs, it clears name value and function returns blank value.
In case i return name from try than its working fine but suppose error comes in try like i write then this try return not executed and control goes to return at the bottom which gives me blank value again.
So , please suggest which technique is best and why.

Posted 11-Jan-14 5:52am

Member 8128040

Updated 11-Jan-14 5:53am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-01-11T05:58:00

Solution 1

There is no solution that allows that: the return value from the finally block will always be used, simply because it is always executed at the end of the try block regardless of what else happens within it: catch or not.

The simplest solution is just to not set name within the finally block:

C#

private string GetName()
    {
    string name = "";
    try
        {
        name = "This is my name";
        //throw new NotImplementedException();
        }
    catch (Exception)
        {
        name = "Error";
        }
    finally
        {
        }
    return name;
    }

Posted 11-Jan-14 5:58am

OriginalGriff

Comments

Member 8128040 11-Jan-14 12:03pm

then wat is the use of finally block.

OriginalGriff 11-Jan-14 12:08pm

It's they to let you clean up after yourself!
Suppose you open a connection to SQL in your try block, and get an error.
You need to close the connection - but you can't just do it in the catch because you would have to duplicate code in the try block. So you do it in the finally block only, and regardless of how your code exits from the try-catch, the connection is always closed.

[no name] 11-Jan-14 13:06pm

Solution and comment +5.

BillWoodruff 11-Jan-14 14:36pm

Keep in mind that you cannot execute a 'return ... or any command that alters the flow-of-control ... inside a 'finally block. You can throw an Exception inside a 'finally block, however (but, why anyone would do that is beyond me).

OriginalGriff 12-Jan-14 4:30am

So that you can report meta-failures when the "normal" system of cleaning up your mess has failed and the user data is at risk as a result.
Suppose your finally block tried to do a manual rollback on SQL and the connection had died perhaps so you didn't know what state the DB is in?

CPallini 11-Jan-14 13:14pm

5.