Returning collection of items

Question

0.00/5 (No votes)

See more:

I am retrieving multiple records from database and storing it in list. I have created properties class and then i assign data being retrieved to variables in properties and then trying to return all collection of values to client who made function call but it doesn't work. Why ? please make it correct.

Code:

C#

public Properties FetchCoordinates(String FetchParam) 
        {
            String[] parts = FetchParam.Split(',');
            sqlCom.CommandText = "FetchCoordinates";
            sqlCom.CommandType = CommandType.StoredProcedure;
    
            sqlCom.Parameters.Add("@IMEI", SqlDbType.VarChar).Value = parts[0].ToString();
            sqlCom.Parameters.Add("@DateTimeFrom", SqlDbType.VarChar).Value = Convert.ToDateTime(parts[1].ToString());
            sqlCom.Parameters.Add("@DateTimeTo", SqlDbType.VarChar).Value = Convert.ToDateTime(parts[2].ToString());
            SqlParameter sqlParam = new SqlParameter("@result", SqlDbType.Int);
            sqlCom.Parameters.Add(sqlParam);
            sqlCom.Parameters["@result"].Direction = ParameterDirection.Output;
            List<Properties> props = new List<Properties>();
            Properties p;
     
            try
            {
                sqlCon.Open();
                using (SqlDataReader reader = sqlCom.ExecuteReader())
    {
                while (reader.Read())
                {
                    p = new Properties()
                    {
                        Longitude = reader["Longitude"].ToString(),
                        Latitude  = reader["Latitude"].ToString()
                    };
                    props.Add(p);
                    return p;
                }
                
    }
               
    
    
            }
    
    
    
            catch (Exception ex)
            {
    
                
    
            }
    
            finally
            {
                sqlCon.Close();
            }
            
        }
    
    }

Properties.cs

C#

public class Properties
    {
        public Properties()
    	{
    	}
    
        public string Longitude { get; set; }
        public string Latitude { get; set; }
    
    }

Posted 15-Apr-14 9:01am

Hunain Hafeez

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

cigwork · Answer 1 · 2014-04-15T09:28:00

The code in q. returns a single property value not a list/array/collection
The method returns after the first row in the data has been read

I've stripped the setup code and exception handling to make the changes easier to see.

C#

// If we want a list of all values then make sure the method returns a list.
public List<Properties> FetchCoordinates(String FetchParam) 
{
   // Chopped for clarity

   List<properties> props = new List<properties>();
   Properties p;
     
   sqlCon.Open();
   using (SqlDataReader reader = sqlCom.ExecuteReader())
   {
     while (reader.Read())
     {
       p = new Properties()
       { Longitude = reader["Longitude"].ToString(),
         Latitude  = reader["Latitude"].ToString()};
        props.Add(p);
       // Don't think you want to do this.
       // return p;
     }
    }
   sqlCon.Close();
  
   // Return _everything_ we read from the DB.
   return props;
   
 }

Were it me I'd also rename the Properties class "Position" or possibly Coordinate as that seems like a better description given its properties.

AnvilRanger · Answer 2 · 2014-04-15T09:29:00

Two things I can see right away.

You need to return a collection of Properties not the Properties object.

public List<properties> FetchCoordinates(String FetchParam) </properties>

Then you need to remove the return in your while loop. Move your return to after the loop.

C#

return props;

Returning collection of items

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0