HTML/JavaScript - function return not right

Question

0.00/5 (No votes)

See more:

In the code below. When I run debugging, the sequence likes that below:
1) At var m = GetArray("VA");
2) At return s; // last line of the function
3) At debugger; // 1st debugger line
4) At debugger; // 2nd debugger line
5) Out of the function. Of course, no value is returned on var m.
How can this bug be fixed? Thanks for your advisory.

When the function GetArray() is called, it always goes to 'return s;' first in debugging

JavaScript

var m = GetArray("VA");
debugger;        // 1st debugger line

function GetArray(s0) {
  var s;
  $.support.cors = true;
  $.ajax({
 	async: true,
	type: 'Get',
	url: myURL,                  // myURL - a global variable 
	dataType: 'json',
	callbackParamName: 'callback',
	crossDomain: true,
	success: function (res) {
          debugger;         // 2nd debugger line
          s = res;                   // hundreds of records 
	},
	error: function (xhr, status, error) {
	  debugger;
	  console.log(error);
	}
   });
   return s;
}

Posted 19-Nov-14 4:00am

s yu

Updated 19-Nov-14 4:02am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

jaket-cp · Accepted Answer · 2014-11-19T05:28:00

Solution 1

The GetArray function is returning the var s without a value as the ajax success call has not occurred yet.
When the Ajax call is successful then the 2nd debugger line is reached.

The success part of the $.ajax call can be modified like so:

JavaScript

...
	success: function (res) {
		AjaxSuccess(res);
	},
...
//comment out the return as the s is not being populated from the ajax call
//	return s;

function AjaxSuccess(result){
//populate the global m here, or do the processing of the result here
	m=result;
}

Hope that makes sense.

Posted 19-Nov-14 5:28am

jaket-cp

Updated 19-Nov-14 6:04am

v2

Comments

jaket-cp 19-Nov-14 12:02pm

When is the m being manipulated?
I assume it is being manipulated before the m is populated with the result from the ajax call.
Also forgot to mention to remove the return s; as it is not being used as you want it to be.
Use the function AjaxSuccess to manipulate the result.

s yu 19-Nov-14 12:03pm

Re-coded and detected the returned value(s). Thanks a lot.

jaket-cp 19-Nov-14 12:04pm

no problem :)