How to Pass query String from master page menu control to content page

Question

0.00/5 (No votes)

See more:

hai,
I'm new to asp.net and been working in the shopping cart project .Now the problem is i have two table one is menu(menuid(primarykey),menuname)and another table products(price,menuid(fk),productname,...)and menu control in master page menucontrol have submenus like men,Dresses,Shirts
Pants
T-shirts
when i click Shirts it should only display the men's Shirts in view Products.aspx page by taking values in query string[menu id]and i have used this code in view Products.aspx

C#

private void BindGridData()
    {
        con.Open();
        
        int menuid = int.Parse(Request.QueryString["MenuId"]);
       string sql = "select * from rsa_ProductItemTable where MenuId='" + menuid + "'";
            SqlDataAdapter da = new SqlDataAdapter(sql, con);
            DataSet ds = new DataSet();
            da.Fill(ds);
            DataList1.DataSource = ds;
            DataList1.DataBind();
            con.Close();
        }

error is Value cannot be null.
Parameter name: String
Please Help me with this do i have to add any think in menu click event.My question is how to pass query string from master page and how to get that in view Products.aspx page it should display results based on menu id.
Thanks in advance

Posted 6-Dec-14 5:26am

kwelpooh

Updated 6-Dec-14 5:27am

DamithSL

v2

Add a Solution

Comments

DamithSL 6-Dec-14 11:29am

can you update the question with how your menu code in master page and how you handle the menu click events

kwelpooh 6-Dec-14 11:48am

<asp:MenuItem ImageUrl="~/Admin/images/Button/Products.png" ToolTip="hower to see products">
<asp:MenuItem ToolTip="Hover to Mens Collections" Text="Mens">
<asp:MenuItem ToolTip="mens Clothing" Text="clothing">
<asp:MenuItem ToolTip="Shirts" Text="Shirts" NavigateUrl="~/View Products.aspx?MenuId={0}">
<asp:MenuItem ToolTip="Pants" Text="Pants">
<asp:MenuItem ToolTip="Tshirts" Text="Tshirts">

<asp:MenuItem ToolTip="Shirts" Text="Shirts" NavigateUrl="~/View Products.aspx?MenuId="Dont know what value come here">

protected void Menu1_MenuItemClick(object sender, MenuEventArgs e)
{

Response.Redirect("~/View Products.aspx?MenuId=" +Menu1.SelectedItem.Value(dont Know Whether its correct or not);
}

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 6-Dec-14 11:52am

I think MenuId is null. Also use Parameterized query to avoid SQL Injection attacks.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Answer 1 · 2014-12-06T05:54:00

Solution 1

change

C#

Response.Redirect("~/View Products.aspx?MenuId=" +Menu1.SelectedItem.Value);

to

C#

Response.Redirect("~/View Products.aspx?MenuId=" +e.Item.Text);

and also use parameterized sql statement
int id;

C#

if (!int.TryParse(Request.QueryString["MenuId"], out id))
{
	string sql = "select * from rsa_ProductItemTable where MenuId=@id";
	SqlDataAdapter da = new SqlDataAdapter(sql, con);
        da.SelectCommand.Parameters.AddWithValue("@id", id);
	DataSet ds = new DataSet();
	da.Fill(ds);
	DataList1.DataSource = ds;
	DataList1.DataBind();
	con.Close();
}

Posted 6-Dec-14 5:54am

DamithSL

Updated 6-Dec-14 6:01am

v2

Comments

kwelpooh 6-Dec-14 12:02pm

Thanks for your time . But menu id is not null I just want to make sure other coding is all correct. ?

DamithSL 6-Dec-14 12:06pm

try with above code and check whether you still get the same error or not.
what is the column type of menuid in your database?

kwelpooh 6-Dec-14 12:19pm

I will try that code & menu id is int

DamithSL 6-Dec-14 12:25pm

that is the one of issue with your code, in your sql statement you have given menuid as string column with ' '
if it is int you can use
where MenuId=" + menuid;
without single quotes, but recommended way is using parameters.

kwelpooh 6-Dec-14 12:54pm

I tried this code and it displays nothing kept break point and tried it takes menu id =0 but menu id in the not null.