How to create elements in xml file

Question

0.00/5 (No votes)

See more:

Hi i am first creating a xml document, and adding date to it, and then i am checking if the document exists then add value to the xml document
i want to generate like this in my xml document

HTML

<book>
  <firstname>Balle</firstname>
  <lastname>Largen</lastname>
</book>
<book>
  <firstname>Kalle</firstname>
  <lastname>Svensson</lastname>
</book>

But my code right now generates like this, when adding data another time

XML

<?xml version="1.0" encoding="utf-8"?>
<book>
  <firstname>Balle</firstname>
  <lastname>Largen</lastname>firstnameKallelastnameSvensson</book>

here is my function

C#

private void CreateXmlDoc()
       {

           var firstname = TextBoxFirstName.Text;
           var lastname =   TextBoxLastName.Text;

           var settings = new XmlWriterSettings();
           settings.Indent = true;
           settings.IndentChars = ("    ");
           settings.CloseOutput = true;
           settings.OmitXmlDeclaration = true;
           DateTime now = DateTime.Now;
           var fileName = Server.MapPath("~") + "ansokningar"+ now.Year+"-"+now.Month+"-"+now.Day+".xml";

           if (!File.Exists(fileName))
           {
               var writer = XmlWriter.Create(fileName, settings);

               writer.WriteStartElement("book");
               writer.WriteElementString("firstname", firstname);
               writer.WriteElementString("lastname", lastname);
               writer.WriteEndElement();
               writer.Flush();
               writer.Close();

           }
           else
           {

               var xDocument = XDocument.Load(fileName);
               var xDoc = new XmlDocument();

               xDoc.CreateElement("book");
               XElement root = xDocument.Element("book");
               if (root != null)
               {

                   root.Add("firstname",firstname);
                   root.Add("lastname", lastname);
               }
               xDocument.Save(fileName);

           }




       }

Posted 25-Dec-14 9:54am

Kurac1

Add a Solution

Comments

Zoltán Zörgő 26-Dec-14 3:57am

Any progress? If you have found my answer of use, please feel free to accept it formally.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Arlert · Answer 1 · 2014-12-25T10:57:00

Take a look here: http://msdn.microsoft.com/en-us/library/bb387089.aspx[^]
In your case:

C#

XElement books =
    new XElement("books",
        new XElement("book",
            new XElement("firstname", "Balle"),                                                 
            new XElement("lastname", "Largen")
        ),
        new XElement("book",
            new XElement("firstname", "Kalle"),                                                 
            new XElement("lastname", "Svensson")
        )
    );

**Zoltán Zörgő** · Answer 2 · 2014-12-25T11:00:00

0) You can have only one root: you need an outer element like books for example.
1) XmlDocument.DocumentElement[^] will get the root.
2) Why mixing XDocument and XmlDocument like this?

I would use something like this (LinqPad demo):

XDocument addBook(string filename, string firstname, string lastname)
{
	XDocument xml;
	XElement books;
	if (File.Exists(filename))
   	{
		xml = XDocument.Load(filename);
		books = xml.Root;
	}
	else
	{
		xml = new XDocument();
		books = new XElement("books");
		xml.Add(books);
	}
	
	books.Add(
		new XElement("book",
			new XElement("firstname", firstname),
			new XElement("lastname", lastname))
	);
	
	xml.Save(filename);
	return xml;
}

void Main()
{
	Console.WriteLine(addBook(@"d:\temp\t.xml","John","Smith"));
}

How to create elements in xml file

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0