Disposing objects dynamically

Question

0.00/5 (No votes)

See more:

I have a class "Disposeable" which passes the object to another class "DisposeObject" which inherits "IDisposable".

But, i couldn't able to dispose the object. Do i miss anythings here.

here is my code

C#

public class Disposeable
    {
        List<object> objDisposableObject;

        public Disposeable(List<object> objDisp)
        {
            objDisposableObject = objDisp;
        }

        public void TestDispose()
        {
            int test = objDisposableObject.Count;

            if (test > 0)
            {
                foreach (var objName in objDisposableObject)
                {
                    Console.WriteLine(objName);
                    DisposeObject obj = new DisposeObject(objName);
                    obj.Dispose();
                }
            }
        }
    }

public class DisposeObject : IDisposable
    {
        bool disposed = false;
        object objToDispose = null;
        public DisposeObject(object objInstance)
        {
            objToDispose = objInstance;
        }

        protected virtual void Dispose(bool disposing)
        {
            if (!disposed)
            {
                if (disposing)
                {
                    //dispose managed resources
                    /* Here i'm not able to Dispose the object 
                       i.e. objToDispose.Dispose(); */
                }
            }
            //dispose unmanaged resources
            //objToDispose = null;
            disposed = true;
        }

        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(objToDispose);
        }
    }

public class Program
    {
        //Program objProgram = new Program();
        static void Main(string[] args)
        {
            Program obj = new Program();
            obj.FetchObjects(obj);
        }

        void FetchObjects(object objProgram)
        {
            List<object> lstTest = new List<object>();
            lstTest.Add(objProgram);
            Disposeable objDisposeable = new Disposeable(lstTest);
            objDisposeable.TestDispose();
        }
    }

Code is executing as i expected. but, not able to achieve what i expected.

I request you to guide me with this.

Thank you,
Sridharan

Posted 11-Jun-15 2:10am

Sri India

Updated 11-Jun-15 2:23am

F-ES Sitecore

v2

Add a Solution

2 solutions

Solution 2

This code does not make sense. Why on earth would you create another object for the sole purpose of destroying another object?

I don't understand why you would do complicated code when it could be very simple if you were using a List<IDisposable> instead.

Although there migth be some sensible usage of that pattern, I think it is too advanced for you at that point given the question and the poor implementation.

Before doing advanced stuff you have to learn the basic. Otherwise, your application might just crash and you won't understand why!

Posted 12-Jun-15 6:22am

Philippe Mori

Comments

Sri India 20-Jun-15 7:14am

Thank you, Philippe.
I thought to keep the disposing logic at a class and to be used in other places.

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2015-06-11T02:30:00

The fact that your parent object DisposeObject implements IDisposable doesn't mean it can then dispose anything that it references internally. The "objToDispose" can only be disposed if *it* implements IDisposable as well.

C#

protected virtual void Dispose(bool disposing)
{
    if (!disposed)
    {
        if (disposing && objToDispose is IDisposable)
        {
            ((IDisposable)objToDispose).Dispose();
        }
    }
    //dispose unmanaged resources
    //objToDispose = null;
    disposed = true;
}

C#

void FetchObjects(object objProgram)
{
    List<object> lstTest = new List<object>();
    // program is not disposable
    lstTest.Add(objProgram);
            
    // SqlConnection is disposable
    lstTest.Add(new SqlConnection());

    Disposeable objDisposeable = new Disposeable(lstTest);
    objDisposeable.TestDispose();
}

Disposing objects dynamically

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Disposing objects dynamically

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us