Click here to Skip to main content
13,258,269 members (41,976 online)
Click here to Skip to main content
Add your own
alternative version

Tagged as

Stats

3.3K views
1 bookmarked
Posted 28 Feb 2010

Refactoring Tips - Tip 3

Rate this:
Please Sign up or sign in to vote.
Refactoring Tips - Tip 3Tip 3In a class,if the expression is repeating across the methods. Then encapsulate/wrap that with either a Property or Method as shown below.This increases the code reuse,easy to extend and maintainBad practicepublic class A{ private int Var1;...
Refactoring Tips - Tip 3

Tip 3

In a class,if the expression is repeating across the methods. Then encapsulate/wrap that with either a Property or Method as shown below.

This increases the code reuse,easy to extend and maintain

Bad practice
 
public class A
{
 private int Var1;
 private int Var2;
 
 private void Method1()
 {
   string s = this.Var1 * this.Var2
   //Some more statements..
 }
 private void Method2()
 {
  string s = this.Var1 * this.Var2
  //Some more statements..
 }
}


Good practice


 public class A
 {
  private int Var1;
  private int Var2;
  private int Expression
  {
    get
    {
      return this.Var1 * this.Var2;
    }
  }
  private void Method1()
  {
    string s = this.Expression
    //Some more statements..
  }
 
  private void Method2()
  {
    string s = this.Expression;
    //Some more statements
  }
 
}


I hope this helps!.

Regards,
-Vinayak

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Share

About the Author

Vinayaka Krishna Shenoy
Architect MindTree Ltd
India India
Motivated achiever who guides organizations in applying technology to business settings, provides added value, and creates project deliverables in a timely manner. An experienced Technical Consultant, have successfully led large project teams of more than 20 people from requirements gathering to implementation and support using C#, .NET ,ADO.NET, ADO.NET Entity Framework,ASP.NET,ASP.NET MVC, WCF and SQL Server.

You may also be interested in...

Comments and Discussions

 
-- There are no messages in this forum --
Permalink | Advertise | Privacy | Terms of Use | Mobile
Web03 | 2.8.171114.1 | Last Updated 1 Mar 2010
Article Copyright 2010 by Vinayaka Krishna Shenoy
Everything else Copyright © CodeProject, 1999-2017
Layout: fixed | fluid