Question about 2 dimensional Array

Question

0.00/5 (No votes)

See more:

C#

#include <iostream.h>
#include <conio.h>
void main()
  {
  clrscr();
  int a[2][3],row,col,max,p=0;
  for(row=0;row<2;row++)
    {
    for(col=0;col<3;col++)
      {
      cout<<"Enter values ";
      cin>>a[row][col];
      }
    }
  max=a[0][0];
  for(row=0;row<2;row++)
    {
    for(col=0;col<3;col++)
      {
      if(max<a[row][col])
        max=a[row][col];
       
      if(max==a[row][col])
        {
        p=row+col+1;
         
        }
      }
    }
  cout<<"Maximum value is "<<max<<endl;
  cout<<"Poistion "<<p;
  getch();
  }

The above program find the maximum value from 2 dimensional array
and also find the position of maximum value.
This program correctly finds the maximum value but not correctly finds the position of maximum value.

[edit]Code indented from flat version - OriginalGriff[/edit]

Posted 15-Dec-12 22:54pm

ALIWAZ

Updated 15-Dec-12 23:02pm

OriginalGriff

v2

Add a Solution

Comments

OriginalGriff 16-Dec-12 5:05am

In what way does it not find the correct position? What is it giving and what were you expecting - try to give us an example.

Jibesh 16-Dec-12 5:05am

why do you need another check condition for setting the position. you may add the position assignment under max =a[row][col]; also row+col+1 ?? is that row +col?

OriginalGriff 16-Dec-12 5:27am

Think about it - it finds the last instance of the max, not the first!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nv3 · Answer 1 · 2012-12-16T00:22:00

The statement

p=row+col+1;

is your cause of trouble. You are trying to squeeze a two-dimensional position into a single int value. That's possible, but in that case the mapping should be unique. With your mapping method position (1,2) and (2,1) would both be mapped to the same value of p.

Try the following instead:

p = row * W + col;

W is the number of elements per row, in your case 3. Now every element of your array will produce a distinct p value.

Besides, the +1 in your method was probably just a way of numbering elements starting with 1 instead of 0. That might be a good idea for human output, but not if you are using the value of p in your program. Zero-based index values are a lot more convenient, particularly when you know that all your index values in a program are zero-based. In other words: Don't mix zero- and one-based.

As an alternative, you can store the position in two separate int variables, for example:

C++

int xMax = -1;
int yMax = -1;

// ... your nested loop

     if (a[row][col] > max)
     {
         max = a[row][col];
         xMax = col;
         yMax = row;
     }

Hope that helps.