Why the data are not updating in table

Question

0.00/5 (No votes)

See more:

Why the data are not updating in table.

My cs coading is given below

C#

void submit(Object s, EventArgs e)
           {
           con.Open();
           com = con.CreateCommand();
           if (con != null)
               {
               com.CommandText = "UPDATE joining SET aname = '" + txtName.Text.Trim() + "',fathname='" + txtFather.Text.Trim() + "' where refno='" + txtRefNo.Text.Trim() + "'";
               try
                   {
                   com.ExecuteNonQuery();
                   System.Web.UI.WebControls.Label lbl1 = new System.Web.UI.WebControls.Label();
                   lbl1.ForeColor = System.Drawing.Color.Yellow;
                   lbl1.BackColor = System.Drawing.Color.Blue;
                   lbl1.Text = "Your record UPDATED sucessfully";
                   ph1.Controls.Add(lbl1);
                   }
               catch (Exception ex)
                   {
                   Response.Write(ex.Message);
                   }
               }
           con.Close();
           }

[edit]Code block added, code formatted, "Treat my content as plain text..." option disabled - OriginalGriff[/edit]

Posted 20-Jan-12 21:43pm

Janardan Pandey

Updated 20-Jan-12 21:56pm

uspatel

v3

Add a Solution

Comments

Kim Togo 21-Jan-12 3:52am

Repost - See http://www.codeproject.com/Questions/317868/Why-the-data-are-not-updating-in-table

Sergey Alexandrovich Kryukov 21-Jan-12 4:17am

Time to report it... :-)
--SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-01-20T21:55:00

Solution 1

Probably, it is down to the contents of your text boxes. Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead:

C#

com.CommandText = "UPDATE joining SET aname = @NM,fathname=@FN where refno=@RN";
com.Parameters.AddWithValue("@NM", txtName.Text.Trim());
com.Parameters.AddWithValue("@FN", txtFather.Text.Trim());
com.Parameters.AddWithValue("@RN", txtRefNo.Text.Trim());

Not only will your code be better protected, but your problem may well go away as well.

Posted 20-Jan-12 21:55pm

OriginalGriff

Comments

Janardan Pandey 21-Jan-12 5:20am

but this is not working

OriginalGriff 21-Jan-12 5:21am

So what is, or isn't happening?

Janardan Pandey 21-Jan-12 5:22am

the data which i want to update in the table not going.

OriginalGriff 21-Jan-12 5:36am

Are you getting any messages?

Janardan Pandey 21-Jan-12 6:01am

no i am not getting any error message.Only showing your record updated.But when i am going to see in the table records is not updated.

OriginalGriff 21-Jan-12 6:10am

Then the most likely explanation is that the refno field is not matching. Try changing your label text:
lbl1.Text = "Your record UPDATED sucessfully(" + count + "," + txtRefNo.Text.Trim() + ")";
and look manually to check that the records you think exist, do.
declare count is an int:
int count = com.ExecuteNonQuery();
and the label will show you how many records where changed, and the refno used to decide which to do.