textbox value validation is not working ?

Question

1.00/5 (2 votes)

See more:

if (Convert.ToInt32(txtTvalidqty.Text) > Convert.ToInt32(txtPlanQty.Text))

Posted 3-Jan-13 22:12pm

Master Vinu

Updated 3-Jan-13 22:16pm

v3

Add a Solution

Comments

CPallini 4-Jan-13 4:15am

And the question is?

Abhishek Pant 4-Jan-13 4:16am

if ((Convert.ToInt32(txtTvalidqty.Text)) > (Convert.ToInt32(txtPlanQty.Text)))

Suvabrata Roy 4-Jan-13 4:17am

What is the problem / error

Master Vinu 4-Jan-13 4:17am

not working ) expected

Abhishek Pant 4-Jan-13 4:22am

try above one I wrote above and if this doesn worked then try CPallini's option of exceptionn handling

Master Vinu 4-Jan-13 4:19am

giving error input string is not valid

CPallini 4-Jan-13 4:21am

This may happen if the input string cannot be converted to an int32. You have to handle such exception.

prashant patil 4987 4-Jan-13 4:35am

i think u have no code sense.
try to improve your question and also yourself..

Reza Alipour Fard 4-Jan-13 4:39am

You must check text in your text box before convert it to int.
If structure of entering text is not valid for convert to int you can clear this text and focus on this before exit from this text box.
You have not any problem in this code, Your problem is related to text structure.

3 solutions

Solution 2

if (Convert.ToInt32(txtTvalidqty.Text) > Convert.ToInt32(txtPlanQty.Text))

-- Check Null value first for both txtTvalidqty.Text and txtPlanQty.Text like this.

C#

if (string.IsNullOrEmpty(txtTvalidqty.Text)) 
{
   txtTvalidqty.Text="0";
}
if (string.IsNullOrEmpty(txtPlanQty.Text))
{
   txtPlanQty.Text="0";
}

if (Convert.ToInt32(txtTvalidqty.Text) > Convert.ToInt32(txtPlanQty.Text))

Hope, this helps.
--
Thanks,
Abhay Bansal

Posted 3-Jan-13 22:31pm

abhay bansal

Updated 3-Jan-13 22:43pm

v4

Comments

fjdiewornncalwe 4-Jan-13 4:37am

You should never check for null or empty in this fashion. Use if(string.IsNullOrEmpty(txtTvalidqty.Text)) notation instead.
You will also still get the error that the input string is incorrect format because the wrong converters are being used. See my answer for the correct way to do this.

Solution 4

Yo can first check the text in textbox like
if(Convert.ToString(txtTvalidqty.Text)!=null && Convert.ToString(txtTvalidqty.Text)!="" && Convert.ToString(txtPlanQty.Text)!=null && Convert.ToString(txtPlanQty.Text)!="")
{
if ((Convert.ToInt32(txtTvalidqty.Text) > Convert.ToInt32(txtPlanQty.Text))
{
//your code
}
}

Posted 3-Jan-13 22:54pm

Pratika05

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Accepted Answer · 2013-01-03T22:35:00

Solution 3

When converting text into numerical values, you should always use the Parse methods rather than the Convert methods.

C#

int value1;
int value2;

Int32.Parse(txtTvalidqty.Text, out value1);
Int32.Parse(txtPlanQty.Text, out value2);

if (value1 > value 2) ...

Posted 3-Jan-13 22:35pm

fjdiewornncalwe

Comments

Aarti Meswania 4-Jan-13 4:42am

5+

fjdiewornncalwe 4-Jan-13 10:21am

Thanks, Aarti.

[no name] 4-Jan-13 5:45am

*****

fjdiewornncalwe 4-Jan-13 10:21am

Thanks, Turbo_23

[no name] 4-Jan-13 10:27am

hi marcus i have one question can you please check it "http://www.codeproject.com/Questions/521548/Convertplus2dplusImageplusintoplus3dplusinplusasp"