styling li containing current a

Question

1.00/5 (1 vote)

See more:

what is wrong with this code:

JavaScript

<script src="http://code.jquery.com/jquery-1.8.3.min.js"></script>
<script>
$(function(){
  $('li').each(function() {
       var href = $(this).find('a').attr('href');
    if (href == window.location.pathname) {
      $(this).addClass('current');
    }
  });
});
</script>

CSS

.current {
  background:red !important;
  color:blue !important;
}

Posted 8-Jul-15 22:14pm

Eng.Yahya92

Add a Solution

Comments

Suvendu Shekhar Giri 9-Jul-15 5:30am

Code looks fine. What is the problem exactly?
Make sure that your anchor (a) tags contain only the folder path without the domain name in it's href.

2 solutions

Solution 2

JavaScript

$(function(){
$('li').each(function() {
var href = $(this).find('a').prop('href');
if (href == window.location.href) {
$(this).addClass('current');
}
});
});

Posted 8-Jul-15 23:46pm

Eng.Yahya92

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Akhil Mittal · Accepted Answer · 2015-07-08T22:36:00

Window.location.pathname gives a "/" before path.make sure "/" is appended in your href value, else compare by removing the slash.I have tried using following code and it worked.Please check,

HTML

<html>
<head>
<script src="http://code.jquery.com/jquery-1.8.3.min.js"></script>
<script>
$(function(){
  $('li').each(function() {
       var href = $(this).find('a').attr('href');
	   console.log(window.location.pathname);
    if (href == window.location.pathname) {
      $(this).addClass('current');
    }
  });
});
</script>
<style>
.current {
  background:red !important;
  color:blue !important;
}
</style>
</script></head>
<body>
<ol>
<li><a href="/C:/Users/akhil.mittal/Desktop/a.html">akhil</a></li>
<li><a href="/C:/Users/akhil.mittal/Desktop/a.html">akhil1</a></li>
<li><a href="/C:/Users/akhil.mittal/Desktop/a.html">akhil2</a></li>
<li><a href="/C:/Users/akhil.mittal/Desktop/a.html">akhil3</a></li>
</ol></body>
</html>