C# an unhandled exception of type 'system.indexoutofrangeexception' occurred in

Question

1.00/5 (1 vote)

See more:

so i made a 2d array and i want to add data into it but i always get this error

An unhandled exception of type 'System.IndexOutOfRangeException' occurred in kwaterminal.exe

this how i did it:

C#

int[,] terain = new int[x1, y1];
int placedmas = 0;
          while (placedmas < LandMasa)
          {
              Random rnd = new Random();
              int x = 0;
              int y = 0;
              x = rnd.Next(0,x1);
              y = rnd.Next(0,y1);

              terain[x1,y1] = 1; //here i get the error
          }

What I have tried:

searchin the error online but i could not find someone who was trying to do the same as me

Posted 21-Jan-18 0:04am

dolfijn3000

Updated 21-Jan-18 0:07am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2018-01-21T00:07:00

Solution 1

In this line:

C#

terain[x1,y1] = 1;

You probably meant [x, y] (the variables you just randomly generated). x1 and y1 are the dimensions you specified earlier, so the "bottom-right" element of this array will be at [x1 - 1, y1 - 1] which makes [x1, y1] out of range.

[Edit]

You'll also have to increase placedmas at some point, or you'll get stuck in an infinite loop.

Posted 21-Jan-18 0:07am

Thomas Daniels

Updated 21-Jan-18 0:13am

v3

Comments

dolfijn3000 21-Jan-18 6:11am

how do i fix this? i need a random location in my array to change into a 1. i tough this would wotk becous i declared x1 and y1 like this : int x1 = 16; int y1 = 25; : and i tought it would not go out of range becous i pick a random number from 0 to x1 and 0 to y1.

Thomas Daniels 21-Jan-18 6:12am

I described in my answer how to fix it: "You probably meant [x, y]"

So, replace [x1,y1] by [x,y].

Thomas Daniels 21-Jan-18 6:12am

Also, you probably have to increase placedmas at some point or it will always be below LandMasa.

dolfijn3000 21-Jan-18 6:14am

well i now see why it was so broken. thx for helping me