Click here to Skip to main content
12,621,477 members (28,702 online)
Click here to Skip to main content
Add your own
alternative version

Tagged as

Stats

2.6K views
1 bookmarked
Posted

Write right

, 24 Jan 2013 CPOL
Rate this:
Please Sign up or sign in to vote.
Regarding use of the various Write and WriteLine methods
Last night a couple of users posted some code snippets with a common inefficiency related to Console.Write. I don't mean to belittle these users' skills, but rather to speak out about whoever is teaching them.

The relevent snippets are: Console.Write(j.ToString()); and Console.Write(counter.ToString() + (innerloop + 1).ToString() + ",");

Yes, the code works as expected, but do you see my concern about inefficiency?

The first one isn't as bad as the second; it can be reduced to: Console.Write(j); because the Write will perform the ToString() anyway so rather than saving effort, you've increased it.

The second one is more of a concern, I recommend: Console.Write("{0}{1}," , counter , innerloop + 1);

I hope you'll agree that using the overload that allows the Format (http://msdn.microsoft.com/en-us/library/8a7aswa4.aspx[^]) makes the code more readable. But it is also more efficient because it avoids a number of intermediate strings.

Many classes provide Write and WriteLine methods; Console and TextWriter are just two, and there's also String.Format and StringBuilder.AppendFormat -- all of these allow the use of a format and I suggest you use it. This (http://msdn.microsoft.com/en-us/library/26etazsy.aspx[^]) should provide some background on formatting.

So, if you are teaching .net, please show your students more than one overload of a method. If you are a student, please investigate all the methods and overloads a class provides; not only what a teacher, a book, or a tutorial demonstrates. If you are using Visual Studio (and you probably are) use Intellisense to see what options you have; use the right tool for the right job.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Share

About the Author

PIEBALDconsult
Software Developer (Senior)
United States United States
BSCS 1992 Wentworth Institute of Technology

Originally from the Boston (MA) area. Lived in SoCal for a while. Now in the Phoenix (AZ) area.

OpenVMS enthusiast, ISO 8601 evangelist, photographer, opinionated SOB, acknowledged pedant and contrarian

---------------

"Using fewer technologies is better than using more." -- Rico Mariani

"Good code is its own best documentation. As you’re about to add a comment, ask yourself, ‘How can I improve the code so that this comment isn’t needed?’" -- Steve McConnell

"Every time you write a comment, you should grimace and feel the failure of your ability of expression." -- Unknown

"If you need help knowing what to think, let me know and I'll tell you." -- Jeffrey Snover [MSFT]

"Typing is no substitute for thinking." -- R.W. Hamming

"I find it appalling that you can become a programmer with less training than it takes to become a plumber." -- Bjarne Stroustrup

ZagNut’s Law: Arrogance is inversely proportional to ability.

"Well blow me sideways with a plastic marionette. I've just learned something new - and if I could award you a 100 for that post I would. Way to go you keyboard lovegod you." -- Pete O'Hanlon

"linq'ish" sounds like "inept" in German -- Andreas Gieriet

"Things would be different if I ran the zoo." -- Dr. Seuss

"Wrong is evil, and it must be defeated." –- Jeff Ello

"A good designer must rely on experience, on precise, logical thinking, and on pedantic exactness." -- Nigel Shaw

“It’s always easier to do it the hard way.” -- Blackhart

“If Unix wasn’t so bad that you can’t give it away, Bill Gates would never have succeeded in selling Windows.” -- Blackhart

"Omit needless local variables." -- Strunk... had he taught programming

You may also be interested in...

Pro
Pro

Comments and Discussions

 
-- There are no messages in this forum --
| Advertise | Privacy | Terms of Use | Mobile
Web01 | 2.8.161128.1 | Last Updated 24 Jan 2013
Article Copyright 2013 by PIEBALDconsult
Everything else Copyright © CodeProject, 1999-2016
Layout: fixed | fluid