The conversion of a varchar data type to a datetime data type resulted in an out-of-range value.

Question

1.00/5 (1 vote)

See more:

I have error The conversion of a varchar data type to a datetime data type resulted in an out-of-range value. in cmd.executescalar()

VB

Public Function checkDate(ByVal tbl As String, ByVal AppId As Double, ByVal col As String, ByVal val As String) As Boolean
            If con.State = ConnectionState.Open Then
                con.Close()
            End If
            Dim valdate As Date = Convert.ToDateTime(val)
            MsgBox(valdate)

            Dim i As Integer

            'databaseConnection(cmd)

            Dim cmd As New SqlCommand("select count(*) from " & tbl & " where appid=" & AppId & " and " & col & "<='" & valdate & "'", con)


            'cmd.CommandText = "select count(*) from " & tbl & " where appid=" & AppId & " and " & col & "<='" & valdate & "'"
            'cmd.CommandType = CommandType.Text
            MsgBox(cmd.CommandText)

            con.Open()
            i = cmd.ExecuteScalar()


            MsgBox(i)
            ' Convert.ToInt32(i)


            If (i > 0) Then
                Return True
            Else
                Return False
            End If
            con.Close()

        End Function

Posted 7-Aug-15 4:11am

Member 11893466

Updated 7-Aug-15 4:27am

Abhishek Pant

v2

Add a Solution

Comments

Richard Deeming 7-Aug-15 11:46am

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
SQL injection attack mechanics | Pluralsight [^]

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-08-07T04:32:00

Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

Then, convert your val to a DateTime instead of passing a string - and check it in your VB code to make sure the user entered a valid value - and pass the DateTime directly to SQL.

The advantage of this - apart from your database not being deleted by a malicious user - is that you have access to the user locale when you do the conversion, so you can generate the correct date from his entry. SQL can't do that, because it doesn't know if the user wanted US MM/dd/yy, European dd/MM/yy, or ISO yy/MM/dd format - so it has to guess.

E.F. Nijboer · Answer 2 · 2015-08-07T04:29:00

Solution 1

DateTime type in t-sql has a limited range. Consider using DateTime2 instead.

DateTime:
Min: 1753-01-01 00:00:00.000
Max: 9999-12-31 23:59:59.997

DateTime2:
Min: 0001-01-01 00:00:00.0000000
Max: 9999-12-31 23:59:59.9999999

Good luck!

Posted 7-Aug-15 4:29am

E.F. Nijboer