Check value from one table in sql and if exists then increment the value in other table

Question

0.00/5 (No votes)

See more:

Hi, I need some help with asp.net, ado.net & sql
I have 2 sql tables. One stores the book information and other table stores the number of copies. what i want is, I want to first check if the book of same name is already present and if book is already present then it should increment the values in copy column of copies table.
for example, first table contains books information with columns like its name,publisher,edition and second table has name and number of copies. so when I add any book information, then it should check booktable based on book name and if same book is present then it should increment value in copies table. this is what i have written but its not working

SqlConnection additemconn = new SqlConnection(strconn);
            additemconn.Open();
            SqlCommand checkcomm = new SqlCommand("if EXISTS(select Bname from Books where Bname='" + txtItemname.Text + "') Update Bookcopies set BooksCopies=BooksCopies + 1 where Bname='" + txtItemname.Text + "' End if");
            checkcomm.Connection = additemconn;
            checkcomm.ExecuteNonQuery();
            
            
            SqlConnection additemconnadd = new SqlConnection(strconn);
            additemconn.Open();
            SqlCommand additemcomm = new SqlCommand("Insert into Books values ('" + txtItemname.Text + "','" + txtitemauthor.Text + "','" + lstitemflagged.Text + "','" + txtitempublisher.Text + "','" + txtitemedition.Text + "','" + txtitemdate.Text + "','" + txtItemId.Text + "') ");
            
            additemcomm.Connection = additemconnadd;
            additemcomm.ExecuteNonQuery();

Posted 4-Sep-10 2:06am

Potalibaba

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Goutam Patra · Answer 1 · 2010-09-04T02:18:00

For your question perhaps you want some sql like

IF EXISTS(select Bname from Books where Bname='NEWBOOKNAME') BEGIN
  Update Bookcopies set BooksCopies=BooksCopies + 1 where Bname='NEWBOOKNAME'
END ELSE BEGIN
 Insert into Books .....
End

in one SQL.

May be you can write a stored procedure instead. and use parameters to avoid injection.

Lantei · Answer 2 · 2010-09-06T01:55:00

Solution 2

Your code will work good if you take off the terminating if in your if..else query block. There is no End If in sql..its only an End

Posted 6-Sep-10 1:55am

Lantei

Sushant Joshi · Answer 3 · 2010-09-06T02:19:00

Solution 3

Firstly, use the storedproc rather than inline queries. Secondly, remove the End If

Posted 6-Sep-10 2:19am

Sushant Joshi