How to add key and value in list keyvaluepair using their object during runtime

Question

1.00/5 (3 votes)

See more:

I am not able to add key and value in List keyvaluepair during runtime. it's overwritting again and again. where i'm doing wrong please correct me.

C#

 List<KeyValuePair<string, string>>

foreach (XmlNode xn in xmlLabelList)
{

     string propert = xn[&quot;name&quot;].InnerText;
              
     string label = xn[&quot;label&quot;].InnerText;
              
     kvpList = new List<KeyValuePair<string, string>>();
     kvpList.Add(KeyValuePair<string,string>(propert, label));

}

What I have tried:

here property and label have some value. that is coming from xml. both should be add in List keyvaluepair

Posted 24-May-16 4:11am

Member 10543687

Updated 24-May-16 4:19am

CHill60

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 24-May-16 10:21am

Why would you have a list of the element of this element type? You can, but why? This type is designed to work with associative containers, such as Dictionary, SortedDictionary, SortedList.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2016-05-24T04:17:00

Solution 1

try this
Dont create the instance of the list inside the loop.

C#

List<KeyValuePair<string, string>> kvpList = new List<KeyValuePair<string, string>>();
         foreach (XmlNode xn in xmlLabelList)
         {
             string propert = xn["name"].InnerText;
             string label = xn["label"].InnerText;
             kvpList.Add(new KeyValuePair<string,string>(propert, label));

         }

Posted 24-May-16 4:17am

Karthik_Mahalingam

Updated 24-May-16 4:18am

v3

Comments

Sergey Alexandrovich Kryukov 24-May-16 10:24am

My 5, but see also my comment to the question.
Also, hard-coding of "name" and "label" is hardly acceptable.
—SA

Karthik_Mahalingam 24-May-16 10:28am

Thanks Sergey,
Yes, he could have chosen dictionary, but to avoid the duplicate key exceptions he might be using List. who knows :)

Sergey Alexandrovich Kryukov 24-May-16 10:31am

How? It's the associative containers and sets are designed to avoid duplicate keys; in lists, the mechanism is meaningless. Manual checkup for uniqueness defeats the purpose and is bad in performance.
—SA

Karthik_Mahalingam 24-May-16 10:33am

may be he is not aware of dictionary type.

Sergey Alexandrovich Kryukov 24-May-16 10:37am

It's not only the dictionary type, and not about awareness of the existence of some times. That's why I raise the issue. It would be a good idea review all types in System.Collections.Generic and at least understand their purpose, before designing any code.
—SA