Help me to solve this error

Question

0.00/5 (No votes)

See more:

This is my button code and i am getting exception on cmd.ExecuteNonQuery();
please let me know where is my mistake :doh: :(( :(( :confused: :(( :((

private void btnsubmit_Click(object sender, EventArgs e)
       {
           string Strmod = textBox5.Text;
           string strPer = comboBox1.SelectedItem.ToString();
           string strFinalPer = Strmod + strPer;


           DateTime date1 = Convert.ToDateTime(dateTimePicker1.Text);
           DateTime date2 = Convert.ToDateTime(dateTimePicker2.Text);
           SqlConnection cnn = new SqlConnection(@"Server=NGENIOUS-WSSDEV\SQLEXPRESS;Database=MIC;Trusted_Connection= True");

           SqlCommand cmd = new SqlCommand("insert into orderbooking(orderdate ,clientname ,deliverylocation,deliverydate,deliverytime)values(@orderdate,@clientname ,@deliverylocation,@deliverydate,@deliverytime)", cnn);
           cnn.Open();
           cmd.Parameters.AddWithValue("@orderdate", date1);

           cmd.Parameters.AddWithValue("@clientname ", txtclient.Text);
           cmd.Parameters.AddWithValue("@deliverylocation ", txtlocation.Text);
          // cmd.Parameters.AddWithValue("@order_ID", textBox1.Text);
          cmd.Parameters.AddWithValue("@deliverydate ", date2);
          cmd.Parameters.AddWithValue("@deliverytime", strFinalPer);


           cmd.ExecuteNonQuery();
           cnn.Close();

           SqlConnection cnn1 = new SqlConnection(@"Server=NGENIOUS-WSSDEV\SQLEXPRESS;Database=MIC;Trusted_Connection= True");
           SqlCommand cmd1 = new SqlCommand("insert into orderdetails(productcode,productname,productcatagory,quantity,spldiscount,units)values(@textBox26.Text,@label12.Text,@label23.Text,@textBox3.Text,@textBox4.Text ,@label17.Text");
           //cnn1.Open();

           cmd1.Parameters.AddWithValue("@productcode",textBox26.Text);

           cmd1.Parameters.AddWithValue("@Quantity", textBox3.Text);
           cmd1.Parameters.AddWithValue("@spldiscount", textBox4.Text);

           cnn1.Open();


           MessageBox.Show ("You Successfully Submited");

           cmd1.ExecuteNonQuery();
           cnn.Close();



       }

i have did connection on text box so that when user put one info rest all three label will display this is working fine but there are three text box which take the data and put in database put it is not happening :mad: :(( :doh: :confused:

private void textBox26_TextChanged(object sender, EventArgs e)
       {
           SqlConnection cnn = new SqlConnection(@"Server=NGENIOUS-WSSDEV\SQLEXPRESS;Database=MIC;Trusted_Connection= True");
           //SqlCommand cmd = new SqlCommand("select * from subproduct where productcode= textBox26");
           cnn.Open();
           DataSet ds = new DataSet();

           string str=textBox26.Text;
           string query = "select * from subproduct where productcode ='"+str+"'";
           SqlDataAdapter adapter = new SqlDataAdapter(query, cnn);
           adapter.Fill(ds);
         //  if (ds.Tables[0].Rows.Count > 0)
           for (int i = 0; i < ds.Tables[0].Rows.Count; i++)
           {
               label12.Text = ds.Tables[0].Rows[i]["productname"].ToString();
               label17.Text = ds.Tables[0].Rows[i]["productcategory"].ToString();
               label23.Text = ds.Tables[0].Rows[i]["units"].ToString();


           }

please help thanks in Advance :rose::rose:

Posted 19-Oct-10 23:40pm

aayu

Updated 20-Oct-10 0:27am

v2

Add a Solution

4 solutions

Solution 1

i think you missed the command connection to the sqlconnection "cnn1"

SqlCommand cmd1 = new SqlCommand("insert into orderdetails(productcode,productname,productcatagory,quantity,spldiscount,units)values(@textBox26.Text,@label12.Text,@label23.Text,@textBox3.Text,@textBox4.Text ,@label17.Text",cnn1);

Posted 19-Oct-10 23:48pm

Rajesh Anuhya

Comments

aayu 20-Oct-10 5:59am

this error is solve.
but now it is telling me must declare scalar the variable @textbox26

DavidKiryazi 20-Oct-10 6:28am

You can't use the '@' keyword infront of textbox26 unless you have textbox26 declared with the '@' symbol in the first place.

ie. What normally happens is you declare a object such as TextBox textbox26 = new TextBox(). This is all well and good. However, it is also possible to delcare it as TextBox @textbox26 = new TextBox(). Then you have an actual variable called @textbox26. Can you see the problem? The "@" has special meanings in C# and one of them is that it allows you to use C# keywords as variable or object names. For example, int @if = 5; is valid.

In short, get rid of the "@" symbols in your command string and all will be well.

Rajesh Anuhya 20-Oct-10 6:41am

See the below answer given by me..

Solution 2

In your code.

SqlCommand cmd1 = new SqlCommand("insert into orderdetails(productcode,productname,productcatagory,quantity,spldiscount,units)values(@textBox26.Text,@label12.Text,@label23.Text,@textBox3.Text,@textBox4.Text ,@label17.Text");

If you are using Direct textbox value then Remove '@' sign in @textBox.Text,
OR
If you are using @textBox as parameter then remove '.Text' Properties,

Like only use TextBox.Text.

Please vote and Accept Answer if it Helped.

Posted 20-Oct-10 0:31am

Hiren solanki

Comments

aayu 20-Oct-10 6:53am

thank you

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mohd Wasif · Accepted Answer · 2010-10-20T00:38:00

Use It U will get the Result.
Just Copy and Paste.

SqlConnection cnn1 = new SqlConnection(@"Server=NGENIOUS-WSSDEV\SQLEXPRESS;Database=MIC;Trusted_Connection= True")
SqlCommand cmd1 = new SqlCommand("insert into orderdetails
(productcode,productname,productcatagory,quantity,spldiscount,units)
values(@productcode,@productname,@productcatagory,@quantity,@spldiscoun ,@units"),cnn1);
//cnn1.Open();

MIDL

cmd1.Parameters.AddWithValue("@productcode",textBox26.Text);
            cmd1.Parameters.AddWithValue("@productname", label12.Text);
            cmd1.Parameters.AddWithValue("@productcatagory", label23.Text");

            cmd1.Parameters.AddWithValue("@quantity",textBox3.Text);
            
            cmd1.Parameters.AddWithValue("@spldiscoun", textBox4.Text);
            cmd1.Parameters.AddWithValue("@units", label17.Text);

            cnn1.Open();
            

            MessageBox.Show ("You Successfully Submited");

            cmd1.ExecuteNonQuery();
            cnn1.Close();

Rajesh Anuhya · Accepted Answer · 2010-10-20T00:41:00

Use the below code

SqlCommand cmd1 = new SqlCommand("insert into orderdetails(productcode,productname,productcatagory,quantity,spldiscount,units)values('" + 
textBox26.Text.ToString() + "','" +
label12.Text.ToString() + "','" +
label23.Text.ToString() + "','" +
textBox3.Text.ToString() + "','" +
textBox4.Text .ToString() + "','" +
label17.Text .ToString() + "')",cnn1);