check whether email id is correct or not using MFC

Question

2.50/5 (2 votes)

See more:

Hi..
I am doing validation of email id, output is coming wrong, when I give email id without "@" also the "valid" message box appears. Don't know whats going wrong,, pls.. help me

C++

void CEMailDlg::OnValidate()
{
    // TODO: Add your control notification handler code here
    CString m_sFrom;
    m_sFrom=IDC_EDIT_FROM;

    for(int a=0;a &lt; m_sFrom.GetLength(); a++)
    {
        if(m_sFrom.GetAt(a)!='@';)
        {
        AfxMessageBox("valid id");
        }
        else
        {
        AfxMessageBox("invalid id");
        }
    }
}

Thank you.

Posted 12-May-11 0:19am

degorio

Updated 12-May-11 4:04am

Joan M

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Joan M · Accepted Answer · 2011-05-12T03:03:00

In your code you must eliminate the ! from the comparison... you are checking if the value is different from @ and showing a VALID message...

You can use...

CString m_sFrom;
GetdlgItemText(IDC_EDIT_FROM, m_sFrom);  // here you are getting the right text...

if (m_sFrom.Find("@")!=-1)
{
  AfxMessageBox("valid");
}
else
{
  AfxMessageBox("Invalid");
}

You could do DDX which is easier to interact...

HTH...

PS: you should follow the advice from John... regex is the way to go... I've only followed your sample correcting the way you are checking the contents on the string and a couple of things more...

#realJSOP · Accepted Answer · 2011-05-12T03:22:00

Solution 2

There are several regex solutions for validating email addresses. All you need is a little google foo.

Posted 12-May-11 3:22am

#realJSOP

Comments

Joan M 12-May-11 9:32am

my 5... and reference from my answer...