BIG if/switch Statement

Question

0.00/5 (No votes)

See more:

I have a big if statement that I turned into a switch, unfortunately I find the switch getting too big. I looked at the hash and map but it's beyond ne at this point. Ideally I would like to store all of this in a header file and just call it from there. Just a piece of the switch. Thank you.

C++

switch (ipsrc) {
	case 192.168.1.0;
	Source = 0.0.0.0;
	break;
	case 165.133.22.1;
	Source = 0.0.0.0;
	break;
	case 192.000.1.1 to 192.000.1.9;
	Source = 0.0.0.0;
	break;
	}

Posted 2-Oct-11 9:22am

Member 7766180

Add a Solution

Comments

Code-o-mat 2-Oct-11 15:32pm

And what is your question?

Member 7766180 2-Oct-11 15:37pm

What else can I do besides having a switch statement with a hundred entries?
Thank you.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sander Rossel · Accepted Answer · 2011-10-02T11:22:00

It seems that what you want here is set the source variable dependent on an IP address.
You want to avoid a big switch statement in code. Correct me if I'm wrong.

I usually handle these kind of cases with a database table that has the cases I need and the value that goes with it.

ID     IPFrom        IPTo          Source
1      192.168.1.0   192.168.1.0   0.0.0.0
3      165.133.22.1  165.133.22.1  0.0.0.0
2      192.000.1.1   192.000.1.9   0.0.0.0

Etc.
Then write a piece of code (or an SP) that checks if the IP (ipsrc) is between any of the IPFrom and IPTo and get the correct Source value for it. Possibly IPTo could be NULL for the first two rows (whatever you like, it's your design).
The upside is that you do not have a huge switch statement and also that if IP addresses change or get added all you have to do is change or add an IP range to your database table.

Hopefully this is any use to you :)