What is wrong with this formatting?

Question

3.50/5 (2 votes)

See more:

I do not see what's wrong.

C#

foreach (DataRow row in dataSet.Tables[0].Rows)
{
    string tmp = String.Format("{0}", row["PZN"].ToString().Trim().PadLeft(7, '0'));
    row["PZN"] = tmp;
    Console.WriteLine(tmp);
    Console.WriteLine(row["PZN"]);
}

gives me output like...

0930673<br />
930673<br />
0148814<br />
148814

Note the missing zeros while printing the row. tried dataSet.Tables[0].AcceptChanges(); no effect. DataSet comes from Excel-File using Microsoft.ACE.OLEDB.12 with about 110 results and is visualized in DataGridView. Everything is working fine except the reassignment/reformatting of the rows.

IMHO this is suppose to work.

Thanks, guys.

Posted 6-Oct-11 9:09am

Oliver Bleckmann

Updated 6-Oct-11 10:15am

André Kraak

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sander Rossel · Accepted Answer · 2011-10-06T09:41:00

Solution 3

My guess is that your row["PZN"] holds an Integer. Your String is successfully parsed as an Integer and will not throw an Exception, but the first 0 gets lost in the conversion ;)

Posted 6-Oct-11 9:41am

Sander Rossel

Comments

Manfred Rudolf Bihy 7-Oct-11 10:48am

There you go, have a 5!

Sander Rossel 7-Oct-11 12:54pm

Thanks! :)

OriginalGriff · Accepted Answer · 2011-10-06T09:34:00

This is probably a little difficult to explain, but row["PZN"] is an object - not anything derived from an object. It is also a fairly special object in that when you assign to it, it gets converted to the underlying type for the DataTable - in this case, int, I suspect from the name. So, when you read it back and ToString it, the underlying datatype is used again, and a standard int-to-string convertion is done.
Try it yourself:

C#

int i = 0;
foreach (DataRow row in dt.Rows)
    {
    string s = i.ToString().PadLeft(7, '0');
    i++;
    object o = s;
    row["myInt"] = s;
    Console.WriteLine("{0}:{1}:{2}", s, o.ToString(), row["myInt"]);
    row["myStr"] = s;
    Console.WriteLine("{0}:{1}:{2}", s, o.ToString(), row["myStr"]);
    }

The results are:

0000000:0000000:0
0000000:0000000:0000000
0000001:0000001:1
0000001:0000001:0000001
0000002:0000002:2
0000002:0000002:0000002

John Y. · Accepted Answer · 2011-10-06T09:31:00

Solution 1

Perhaps (and this is just kind of a guess) its because tmp is declared explicitly as a string, and row["PZN"] isn't?

Posted 6-Oct-11 9:31am

John Y.

Oliver Bleckmann · Accepted Answer · 2011-10-07T04:22:00

Solution 4

dataSet.Tables[0].Columns["PZN"].DataType = System.Type.GetType("System.String");

fixed it, column was set to decimal or double.

Posted 7-Oct-11 4:22am