Incorrect syntax near 'System.Data.DataRowView'.

Question

0.00/5 (No votes)

See more:

SQL

dbCommand = new SqlCommand("SELECT CountryName, Results.CountryId FROM Results,Country WHERE Country.CountryId = Results.CountryId AND GameId '" + cboGameID.SelectedValue + "'", dbConnection);

dbAdapter = new SqlDataAdapter(dbCommand);
dsResults = new DataSet();
dbAdapter.Fill(dsResults, "results");
cboCountryName.DataSource = dsResults.Tables["results"];
cboCountryName.DisplayMember = "CountryName";

Posted 16-Oct-11 7:49am

Eupho

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2011-10-16T08:19:00

Solution 1

SQL

AND GameId '" + cboGameID.SelectedValue + "'", dbConnection);

You need an equal to after the field GameId -> AND GameId = '" + cboGamied.SelectedValue...

Posted 16-Oct-11 8:19am

Abhinav S

Comments

Sander Rossel 16-Oct-11 17:32pm

That would probably be it, +5. See my answer for another big mistake in the code though ;)

Abhinav S 17-Oct-11 0:26am

Yup will do.

Sander Rossel · Answer 2 · 2011-10-16T11:31:00

Well Abhinav probably gave you the right answer already. I want to add though that doing what you are doing is not a good practice. You should aways parameterize your queries for performance and safety (all those SQL injection attacks you've been hearing about were caused by queries that were not parameterized!) ;)
Try the following instead!

C#

dbCommand = new SqlCommand("SELECT CountryName, Results.CountryId FROM Results,Country WHERE Country.CountryId = Results.CountryId AND GameId = @GameId '");
cmd.Parameters.AddWithValue("@GameId", cboGameID.SelectedValue);

@GameId will be replaced with the value you specified in the parameter and SqlServer does the rest :)
No SQL injection, no performance hit, your query will be cached, your code looks cleaner, everyone wins!

Hope that helps :)