Invalid column name 'sddd'.

Question

0.00/5 (No votes)

See more:

Hello guys :D

I'm Trying to teach myself WEBSERVICE and i think its doing pritty good so far, Unfortunetly i got an Error with my WEBSERVICE Database when i try to extract a value out of my DB it gives me a run time error named: "Invalid column name 'sddd'."

heres a part of my code: (it heppens in all my function for some reason)

VB

Function IDExist(ByVal iDNum As String) As Boolean
    sqlConn.ConnectionString = connectString
    sqlConn.Open()
    Dim strSQL As String = "SELECT IDNum FROM ProgDB WHERE (IDNum = " & iDNum & ")"
    sqlCMD.Connection = sqlConn
    sqlCMD.CommandText = strSQL
    Dim i As String = sqlCMD.ExecuteScalar
    sqlConn.Close()
    Dim exist As Boolean = False
    If i <> Nothing Then
        exist = True
    End If
    Return exist
End Function

Thank You in Advance, Tsahi.

Posted 19-Oct-11 7:43am

tsahi-al

Add a Solution

2 solutions

Solution 2

SQL Injection ALERT! *Red lights flashing!*

VB

Dim strSQL As String = "SELECT IDNum FROM ProgDB WHERE IDNum = @myParam"
sqlCMD.CommandText = strSQL
cmd.Parameters.AddWithValue("@myParam", iDNum)

This replaces @myParam with the value of iDNum. SQL takes care of the rest. So if @myParam is a varchar and your user would have typed "D'Artagnan" your query would have failed in your example (try pasting that exact string with D'Artagnan in SQL, won't work because the ' breaks your command). However, by using parameters everything goes well. As a bonus your queries are cached an can be re-used boosting performance! And your code looks cleaner since there is no weird string concatenation.
It's a win win win win situation...
Sony was down for days because of SQL Injection, it cost them millions, don't make that same mistake!
Learn from little Bobby Tables[^] :)

P.S. Coming to think of it, in this example I am not quite sure if you should say '@myParam' with or without the quotes, but using parameters is definitly the way to go!

Posted 19-Oct-11 9:06am

Sander Rossel

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Accepted Answer · 2011-10-19T07:57:00

Solution 1

In your code:
Dim strSQL As String = "SELECT IDNum FROM ProgDB WHERE (IDNum = " & iDNum & ")"

iDNum is defined as as string, so you should probabaly quote the value in your sql statement.
Without quoting this, the sql server will look for a column named the same as your iDNum value.

Like this: (Note the single quote added before and after teh IDNum parameter)
Dim strSQL As String = "SELECT IDNum FROM ProgDB WHERE (IDNum = '" & iDNum & "')"

Posted 19-Oct-11 7:57am

fjdiewornncalwe

Comments

tsahi-al 19-Oct-11 14:02pm

WORKED! Thank you!!

Mehdi Gholam 19-Oct-11 14:46pm

Nice catch, 5!

Sander Rossel 19-Oct-11 15:09pm

Yeah, that does it... But what you REALLY should have said was SQL Injection! ;)

fjdiewornncalwe 19-Oct-11 15:42pm

Ah yes. Of course. I've only been functioning because of Advil for the last two days, so I was quite proud of myself for catching the initial syntax error... :)