nothing will insert into the data

Question

4.00/5 (1 vote)

See more:

why doesnt this work?

C#

 private void button1_Click(object sender, EventArgs e)
        
{
                string ConnectionString = @"Data Source=PHIL-PC\SQLEXPRESS;Initial Catalog=Sudoku;Integrated Security=True";
                
                SqlConnection conn = new SqlConnection(ConnectionString);
                conn.Open();
                string namesub = nameTextBox.Text;
                string emailsub= emailTextBox.Text;
                string SQL1 = "insert into player(Player_name,Player_email) values (" + "'" + namesub + "'" + "," + emailsub + " )";
                SqlCommand cmd1 = new SqlCommand(SQL1, conn);             
                cmd1.ExecuteNonQuery();
                this.player1TableAdapter.Fill(this.sudokuDataSet.player1);
                conn.Close();

sorry im not very knowledgeable in programming, but ill try explain things better. the thing i want done is that the values put in by the user from the nameTextBox and emailTextbox (in the visual studio form) to be inserted into the "player" table in the sql database. i am using this template from a previous example. the error that comes up is associated with cmd1.ExecuteNonQuery(); line it says "The name "asdfafs" is not permitted in this context. Valid expressions are constants, constant expressions, and (in some contexts) variables. Column names are not permitted. "

Posted 12-Jun-12 21:14pm

Member 9113459

Updated 12-Jun-12 22:01pm

v5

Add a Solution

Comments

Sebastian T Xavier 13-Jun-12 3:47am

post your error message

5 solutions

Solution 2

There are quite a few reasons why this may not work: firstly, do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead. This may cure your problem without additional work.
string ConnectionString = @"Data Source=PHIL-PC\SQLEXPRESS;Initial Catalog=Sudoku;Integrated Security=True";

C#

SqlConnection conn = new SqlConnection(ConnectionString);
conn.Open();
string namesub = nameTextBox.Text;
string emailsub= nameTextBox.Text;
string SQL1 = "insert into player(Player_name,Player_email) values (@NM, @EM)";
SqlCommand cmd1 = new SqlCommand(SQL1, conn); 
cmd1.Parameters.AddWithValue("@NM", namesub);
cmd1.Parameters.AddWithValue("@EM", emailsub);
cmd1.ExecuteNonQuery();

But it would be worth checking if you really wanted the name in both the name and email fields...

Posted 12-Jun-12 21:23pm

OriginalGriff

Updated 12-Jun-12 21:46pm

v2

Solution 1

What does the following code?

C#

this.player1TableAdapter.Fill(this.sudokuDataSet.player1);

Whats the error message you are getting? (without that we can't help you)
If you are not receiving any error message, please use proper exception handling.
I suspect the issue is with connection string. Have you missed the password?

Best Regards
Sebastian

Posted 12-Jun-12 21:19pm

Sebastian T Xavier

Updated 12-Jun-12 21:28pm

v3

Solution 3

Try to do a step by step Debug,

First try to put user and pass in connection string, just in case.
then if you have SQL management studio installed try to copy the query manually.
if thats ok to then check if all objects are instantiated

And maybe after inserting do a dataset refresh just in case

Posted 12-Jun-12 21:27pm

Mendor81

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nileshbhai · Accepted Answer · 2012-06-12T21:44:00

Solution 4

I think you have made a mistake in

"insert into player(Player_name,Player_email) values (" + "'" + namesub + "'" + "," + emailsub + " )"

statement.

if you see this line carefully, then you seee, the comma is missing from the "emailsub".

put like

C#

string SQL1 = "insert into player(Player_name,Player_email) values (" + "'" + namesub + "'" + ",'" + emailsub + "' )";

Thanks,
Nilesh

Posted 12-Jun-12 21:44pm

Nileshbhai

Comments

stib_markc 13-Jun-12 4:28am

5!

Vani Kulkarni 13-Jun-12 4:55am

Good one!

Member 9113459 · Accepted Answer · 2012-06-12T22:19:00

forgot to insert a value into a third text box which waas the primary key..and the syntax in the insert part.
thanks for help everyone..i can submit my assignment on time now
correct result
string ConnectionString = @"Data Source=PHIL-PC\SQLEXPRESS;Initial Catalog=Sudoku;Integrated Security=True";
SqlConnection conn = new SqlConnection(ConnectionString);
conn.Open();
string namesub = nameTextBox.Text;
string emailsub= emailTextBox.Text;
string idsub = player_idTextBox.Text;
string SQL1 = "insert into player(player_id,Player_name,Player_email) values (" + "'" + idsub + "'" + "," + "'" + namesub + "'" + "," + "'" + emailsub + "'" + ")";
SqlCommand cmd1 = new SqlCommand(SQL1, conn);
cmd1.ExecuteNonQuery();
this.player1TableAdapter.Fill(this.sudokuDataSet.player1);
conn.Close();

nothing will insert into the data

5 solutions

Solution 2

Solution 4

Solution 1

Solution 3

Solution 5

Add your solution here

Preview 0

Existing Members

...or Join us