Invalid attempt to call MetaData when reader is closed.?

Question

0.00/5 (No votes)

See more:

Hi All,

While retrieving data from database getting this error "Invalid attempt to call MetaData when reader is closed". (Windows application with c# coding)

C#

private void textBox10_TextChanged(object sender, EventArgs e)
{
    //Retrieve Antenatal Details
    //Here textbox10 = PersonID field in antenatal form.
    SqlConnection con = new SqlConnection(strConn);
    con.Open();
    SqlCommand cmd = new SqlCommand("sp_get_antenatal", con);
    cmd.CommandType = CommandType.StoredProcedure;
    cmd.Parameters.AddWithValue("@person_id", textBox10.Text);
    SqlDataReader dr = cmd.ExecuteReader();
    if (dr.Read())
    {
        cbPlaceoforder.SelectedValue = dr["antenatal_care_id"].ToString();
        txtAgeofantenatalmother.Text = dr["age"].ToString();
        if (dr["regular_anc"].ToString().Equals("Yes"))
        {
            rbtnRegularancyes.Select();
        }
        else
        {
            rbtnRegularancno.Select();
        }
    }
    con.Close();
    //Retrieve Lactating details
    con.Open();
    SqlCommand cmd1 = new SqlCommand("sp_get_lactating", con);
    cmd1.CommandType = CommandType.StoredProcedure;
    cmd1.Parameters.AddWithValue("@person_id", textBox10.Text);
    SqlDataReader dr1 = cmd1.ExecuteReader();
    if (dr1.Read())
    {
        cbPlaceofanc.SelectedValue = dr1["delivery_place_id"].ToString();
        cbTypeofdelivery.SelectedValue = dr1["delivery_type_id"].ToString();
        cbMilksupplement.SelectedValue = dr1["milk_suppliment_id"].ToString();
        if (dr["breast_feeding"].ToString().Equals("Yes"))
        {
            rbtnBreastfeeding1stsixmonthsyes.Select();
        }
        else
        {
            rbtnBreastfeeding1stsixmonthsno.Select();
        }
    }
    con.Close();
}

How to resolve this issue?

Thanks and Regards,
Murali.K

Posted 2-Jan-13 0:22am

muralikrishna53

Add a Solution

Comments

Jibesh 2-Jan-13 6:36am

which line you are experiencing this error? post the exception stack for better understanding. As explained its always better to close the dataReader when you are done with the data Reader.

[no name] 2-Jan-13 6:45am

if (dr["breast_feeding"].ToString().Equals("Yes"))

Above line the error getting.

Jibesh 2-Jan-13 7:02am

datareader dr is already closed and you are trying to access a closed connection. check my solution.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Aditya Magotra · Answer 1 · 2013-01-02T00:27:00

Solution 1

hi,

Use this

SqlDataReader dr = cmd.ExecuteReader();
if (dr!=null && dr.HasRows)
{
  While(dr.Read())
  {

   // Do what ever you want
  }
  dr.Close();
}

Posted 2-Jan-13 0:27am

Aditya Magotra

sisir patro · Answer 2 · 2013-01-02T00:44:00

Hi,

Here in the following code you are accessing the data reader and not closing it explicitly.

C#

if (dr.Read())
            {
                cbPlaceoforder.SelectedValue = dr["antenatal_care_id"].ToString();
                txtAgeofantenatalmother.Text = dr["age"].ToString();
                if (dr["regular_anc"].ToString().Equals("Yes"))
                {
                    rbtnRegularancyes.Select();
                }
                else
                {
                    rbtnRegularancno.Select();
                }
            }
            dr.Close();
            con.Close();

So change the code by closing the dara reader before the con object is closed.
This will resolve your problem.

Thanks

Jibesh · Answer 3 · 2013-01-02T01:01:00

Solution 3

You are trying to access the reader value on a closed object. i.e

Quote:
if (dr["breast_feeding"].ToString().Equals("Yes"))

is called after the prev connection is closed. what you can do here is copy this value into a local variable and use that here instead of using the dataReader.

C#

bool breastFeeding = false;
if (dr.Read())
 {
      cbPlaceoforder.SelectedValue = dr["antenatal_care_id"].ToString();
      txtAgeofantenatalmother.Text = dr["age"].ToString();
      if (dr["regular_anc"].ToString().Equals("Yes"))
      {
         rbtnRegularancyes.Select();
      }
       else
       {
         rbtnRegularancno.Select();
        }
      breastFeeding = dr["breast_feeding"].ToString().Equals("Yes")?true:false;
   }
  con.Close();

then use it like below

C#

if (dr1.Read())
{
        cbPlaceofanc.SelectedValue = dr1["delivery_place_id"].ToString();
        cbTypeofdelivery.SelectedValue = dr1["delivery_type_id"].ToString();
        cbMilksupplement.SelectedValue = dr1["milk_suppliment_id"].ToString();
        if (breastFeeding)
        {
               rbtnBreastfeeding1stsixmonthsyes.Select();
          }
         else
           {
               rbtnBreastfeeding1stsixmonthsno.Select();
            }          
 }

Posted 2-Jan-13 1:01am

Jibesh

Comments

[no name] 2-Jan-13 7:52am

This time getting error below line.
breastFeeding = dr["breast_feeding"].ToString().Equals("Yes")?true:false;

"IndexOutof range exception was unhanded".

Jibesh 2-Jan-13 7:54am

can you update your code using Improve Question link. post the updated code. so that we can see what went wrong.

[no name] 2-Jan-13 23:27pm

I have modified my code like you.

private void textBox10_TextChanged(object sender, EventArgs e)
{
bool breastFeeding = false;
//Retrieve Antenatal Details
//Here textbox10 = PersonID field in antenatal form.
SqlConnection con = new SqlConnection(strConn);
con.Open();
SqlCommand cmd = new SqlCommand("sp_get_antenatal", con);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@person_id", textBox10.Text);
SqlDataReader dr = cmd.ExecuteReader();
if (dr.Read())
{
cbPlaceoforder.SelectedValue = dr["antenatal_care_id"].ToString();
txtAgeofantenatalmother.Text = dr["age"].ToString();
if (dr["regular_anc"].ToString().Equals("Yes"))
{
rbtnRegularancyes.Select();
}
else
{
rbtnRegularancno.Select();
}
breastFeeding = dr["breast_feeding"].ToString().Equals("Yes") ? true : false;
}
//dr.Close();
con.Close();
//Retrieve Lactating details
con.Open();
SqlCommand cmd1 = new SqlCommand("sp_get_lactating", con);
cmd1.CommandType = CommandType.StoredProcedure;
cmd1.Parameters.AddWithValue("@person_id", textBox10.Text);
SqlDataReader dr1 = cmd1.ExecuteReader();
if (dr1.Read())
{
cbPlaceofanc.SelectedValue = dr1["delivery_place_id"].ToString();
cbTypeofdelivery.SelectedValue = dr1["delivery_type_id"].ToString();
cbMilksupplement.SelectedValue = dr1["milk_suppliment_id"].ToString();
if (dr["breast_feeding"].ToString().Equals("Yes"))
{
rbtnBreastfeeding1stsixmonthsyes.Select();
}
else
{
rbtnBreastfeeding1stsixmonthsno.Select();
}
}
//dr1.Close();
con.Close();
}

Error: breast_feeding "Index out of Range Exception was unhandled.

Jibesh 2-Jan-13 23:49pm

did you check 'breast_feeding' field is being selected or available in the selected list? check for any misspell.