Create a program which filters the numbers in a file that are perfect squares. Aperfect square is a number that can be expressed as the product of two equal integers(e.g.9=3∗3)

Question

1.00/5 (1 vote)

See more:

How do I filter my file for perfect squares

What I have tried:

C

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define BUFFER_SIZE 1024

int main(){
    char buffer[BUFFER_SIZE] = {0};
    fgets(buffer, BUFFER_SIZE, stdin);
    int     length = strlen(buffer);
    if(buffer[length-1] == '\n' ){
        buffer[length-1] = 0;
    }

    FILE *fp = fopen("buffer", "r");
    if(fp == NULL){
        printf("File not found\n");
        return 1;
    }
    int c = 0;
    while(fgets(buffer, BUFFER_SIZE, fp) >= 48 && <= 57 ){

        printf("%c", c);
    }

    fclose(fp);

    return 0;
}

Posted 2-Dec-20 15:14pm

Somil Ajmera

Updated 2-Dec-20 20:12pm

CPallini

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

k5054 · Accepted Answer · 2020-12-02T16:35:00

C

int c = 0;
while(fgets(buffer, BUFFER_SIZE, fp) >= 48 && <= 57 ){
   printf("%c", c);
}

1) fgets returns a pointer to the buffer. It is highly unlikely that the address of the buffer will be between 48 and 57
2) The code && <= 57 is not valid C. Every comparison operator requires a left side and a right side. C does not string operators together like that.
3) What are the magic numbers 48 and 57? if you mean '0' and '9' use them, it will make it easier to understand when you review the code later on.
4) You never assign anything to int c, so this will always output a 0.

You probably want to look at the function atoi(), which will convert ascii strings to integers. Then you'll probably want to write a function that determines if an integer is a perfect square or not. For that, you might need to look at the sqrt() function.
For bonus points, you might want to think what you should do if the input line is something like "41Z3Q".