I want to fix my code

Question

0.00/5 (No votes)

See more:

I want to make a simple code that starts with entering random letters and numbers
Then the program collects the numbers only

I have a problem with the combination

What I have tried:

#include <iostream>
#include <string>
#include <cstdlib>

using namespace std;

int main()
{
    string serialcode="a98991G343m163R77Eqc\n";

    int i=0;
    int hjg;
    cout<<serialcode;
    int the_sum=0;
    while (i<21)
    {

        if(isdigit(serialcode[i]))
        the_sum+=serialcode[i];

        i++;
    }

    cout<<the_sum;



     return 0;
}

Posted 24-Dec-21 3:03am

191 A

Updated 24-Dec-21 3:31am

v2

Add a Solution

Comments

191 A 24-Dec-21 9:04am

the total is not correct how can i fix this code?

2 solutions

Solution 2

This line

the_sum+=serialcode[i];

should be

the_sum+= serialcode[i] - '0';

If you are working with string, then better use the capabilities of sting:

int main()
{
    string serialcode="a98991G343m163R77Eqc\n";

    cout<<serialcode;
    int the_sum=0;
    for (int i= 0; i < serialcode.length(); i++)
    {

        if(isdigit(serialcode[i]))
            the_sum+= serialcode[i] - '0';
    }

    cout<<the_sum;

     return 0;
}

Posted 24-Dec-21 3:31am

0x01AA

Updated 24-Dec-21 3:43am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2021-12-24T03:25:00

You need to understand that a character digit is not its base value. It is a printable representation of a number. So to accumulate the values of these numbers you first need to convert them to their base integral value. Fortunately with single characters it is simply a matter of subtracting the character '0' from them. So change your code to read:

C++

the_sum += serialcode[i] - '0';

Also your while expression should use the length attribute of the string, rather than a fixed value:

C++

while (i < serialcode.length())