Retrieve Data from sql Server Using C#

Question

1.00/5 (1 vote)

See more:

Hi everyone,

I need a help ! I am writing a programming that select that from two different tables, but it always show this error when ever i run it: Incorrect syntax near '@PayrollNumber'....This is my code:

cmd.CommandText = "SELECT PersonalDetails.FirstName, PersonalDetails.MiddleName, PersonalDetails.LastName, offices.Id, offices.Name   FROM PersonalDetail INNER JOIN offices ON (PersonalDetails.@PayrollNumber = offices.PayrollNumber) WHERE (FirstName =  '" + TextBox6.Text + "') and (MiddleNam<e = '" + TextBox7.Text + "') AND (LastName = '" + TextBox8.Text + "')";

Posted 11-Mar-13 5:12am

rijaalu

Updated 11-Mar-13 5:13am

Richard C Bishop

v2

Add a Solution

Comments

Richard C Bishop 11-Mar-13 11:15am

If @PayrollNumber is not a column in the PersonalDetail table, then you cannot treat it as one. Also, you are leaving yourself open for sql injection. You should be using parameterized queries.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matej Hlatky · Answer 1 · 2013-03-11T05:19:00

Solution 1

Your code contains at least two syntactic errors - “@PayrollNumber” and “MiddleNam<e”.
For user inputs use Command parameters[^] instead of string concatenation.

Posted 11-Mar-13 5:19am

Matej Hlatky