Recursion c++ wininet

Question

3.00/5 (2 votes)

See more:

Im trying to upload a directory and all the files in it to a server using wininet.

here is my code

C++

BOOL CListfilesDlg::recursion(CString sPath) // sPath is the folder name
{
    HANDLE hFind;
    WIN32_FIND_DATA fdFind;
    UpdateData(true);

    CString StrPathS = m_editvalue; //m_editvalue has the full path of the folder im viewing in a listcontrol

    CString salvation =  StrPathS + sPath;
    UpdateData(false);

    CString ren = salvation + "*.*";
    hFind = FindFirstFile( ren, &fdFind );

    do
    {
        if( fdFind.dwFileAttributes == FILE_ATTRIBUTE_DIRECTORY )
        {

if(IsDots(fdFind.cFileName)) continue;
            FtpCreateDirectory(hIConnect,fdFind.cFileName);
            UpdateData(true);
            CString cov = sPath;
            CString fire = m_editvalue;
            UpdateData(false);
            CString newPath =  fire + cov + "\\" + fdFind.cFileName;
            recursion(newPath);
        }
        if(fdFind.dwFileAttributes == FILE_ATTRIBUTE_ARCHIVE)
            continue;
        else
        {
        }
    }
    while( FindNextFile( hFind, &fdFind ) );

    return recursion(sPath);
}

Can someone fix the code? I tried debugging with no luck...

Posted 23-Jul-13 12:58pm

terry mobley

Updated 23-Jul-13 14:20pm

v5

Add a Solution

Comments

pasztorpisti 23-Jul-13 19:21pm

I wouldn't filter for the archive flag, treat everything as file that is not a directory. Inserting a few log statements would be very useful besides debugging. Log out every strings before and after modification. Log out every errors. And so on... Such a function usually have bugs like missing '\\' characters...

[no name] 23-Jul-13 22:06pm

This is a big ask as you have not mentioned anything about what the problem is.

[no name] 23-Jul-13 22:05pm

Agreed - I think this critter can only be debugged in situ. Things like is it finding directory etc etc.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Fredrik Bornander · Answer 1 · 2013-07-23T21:42:00

you shouldn't reuse a global like m_editvalue inside your recursive function like that, it will build up the wrong string. Instead, try to pass in the value of m_editvalue when calling the function and then have the function create new paths based on the input rather than the members of the surrounding class.

Something like this might work for you;

C++

void CListfilesDlg::recursion(CString sPath)
{
  HANDLE hFind;
  WIN32_FIND_DATA fdFind;
    
  UpdateData(true);
 
  CString ren = sPath + "\\*.*";
  hFind = FindFirstFile( ren, &fdFind );
 
  do
  {
    if( fdFind.dwFileAttributes == FILE_ATTRIBUTE_DIRECTORY )
    {
      if(IsDots(fdFind.cFileName)) 
        continue;
            
      FtpCreateDirectory(hIConnect,fdFind.cFileName);
 
      // I left these calls in, I don't know how relevant they are
      // after my changes           
      UpdateData(true);
      UpdateData(false);
            
      CString newPath = sPath + "\\" + fdFind.cFileName;
      recursion(newPath);
    }

    if(fdFind.dwFileAttributes == FILE_ATTRIBUTE_ARCHIVE)
      continue;
  }
  while(FindNextFile( hFind, &fdFind ) );
}

Call the function like this; recursion(m_editvalue); and it should work.

Hope this helps,
Fredrik