Replace an old variable with a random variable using arrays?

Question

2.50/5 (2 votes)

See more:

Hey guys, I've been trying to type this code that will replace an old variable's value with a new value. **Im using graphics with this code** Note that the value is also a variable. So in short, it's a variable in a variable.
**(I know the question is long, but please, just bear with me)**

These are the variables that I declared that were key to this part of code in my game
**Game I'm trying to make is called Piano Tiles (it's a my assigned game to remake for my school project, to make things brief here's a video that explains the game (it's quick to the point): https://www.youtube.com/watch?v=4uZPiynHRsw[^]

C#

int x, y;
//x = ClientRectangle.Width;
//y = ClientRectangle.Height;

Brush bsh_black, bsh_grey, bsh_white, bsh_red;

Brush bc1, bc2, bc3, bc4;

int[] pat_select;

Random pat_ch = new Random();

int pat_assign;

C#

3
InitializeComponent();
yf1 = 0;

bsh_black = new SolidBrush(Color.Black);
bsh_grey = new SolidBrush(Color.Gray);
bsh_white = new SolidBrush(Color.White);
bsh_red = new SolidBrush(Color.Red);

bc1 = bsh_white;
bc2 = bsh_white;
bc3 = bsh_white;
bc4 = bsh_white;

I declared these variables at the top of the page. The "bc" variables, I used as short for "brush changer." So that the brush will change according to the if conditions (will be displayed below this)

For "testing" purposes of my game, temporarily, I used yf1 as the variable that continually makes the row go down with the **timer** I coded it to. **As the timer ticks, I typed in "yf1++;".

C#

if (dummy_state == 0)
{
    game.FillRectangle(bc1, x1, yf1, x2, y2);
    game.FillRectangle(bc2, x2, yf1, x2, y2);
    game.FillRectangle(bc3, x3, yf1, x2, y2);
    game.FillRectangle(bc4, x4, yf1, x2, y2);
}

C#

private void Block_Timer_Tick(object sender, EventArgs e)
{
    yf1++;
    Invalidate();
}

So what I intended to do here was, when the "yf1" variable's value is greater than the form's vertical length AND whatever the "pat_assign" variable equals then the brushes will change to a certain color. And for the "pat_select" variable (shown from the top of this question), if a certain pattern (for example "pat4" variable) is already chosen, then the arrays list would be rearranged and exclude the currently selected pattern.

C#

if (yf1 > y)
{
    //the original array is 
    //pat_select = new int[4] {pat1, pat2, pat3, pat4};
    if (pat_assign == pat4)
    {
        pat_select = new int[3] { pat1, pat2, pat3 };
    }

    if (pat_assign == pat3)
    {
        pat_select = new int[3] { pat1, pat2, pat4 };
    }

    if (pat_assign == pat2)
    {
        pat_select = new int[3] { pat1, pat3, pat4 };
    }

    if (pat_assign == pat1)
    {
        pat_select = new int[3] { pat2, pat3, pat4 };
    }
    #region when pat_assign equals pat1
    if (pat_assign == pat1)
    {       
        bc1 = bsh_black;
        bc2 = bsh_white;
        bc3 = bsh_white;
        bc4 = bsh_white;
        Invalidate();
    }
    #endregion
    #region when pat_assign equals pat2
    if (pat_assign == pat2)
    {
        bc1 = bsh_white;
        bc2 = bsh_black;
        bc3 = bsh_white;
        bc4 = bsh_white;
        Invalidate();
    }
    #endregion
    #region when pat_assign equals pat3
    if (pat_assign == pat3)
    {
        bc1 = bsh_white;
        bc2 = bsh_white;
        bc3 = bsh_black;
        bc4 = bsh_white;
        Invalidate();
    }
    #endregion
    #region when pat_assign equals pat4
    if (pat_assign == pat4)
    {
        bc1 = bsh_white;
        bc2 = bsh_white;
        bc3 = bsh_white;
        bc4 = bsh_black;
        Invalidate();
    }
    #endregion
    yf1 = 0 - y2;
}

Unfortunately when the graphic went back to the top of the form, it didn't change the pattern at all, but stayed with the current pattern it had. What's the problem with it? I don't really see anything...

UPDATE:
Here is the PainEventHandler:

C#

private void Form1_Paint(object sender, PaintEventArgs e)
        {
            Graphics game = e.Graphics;

            yf2 = yf1 - (y / 4);

            if (dummy_state == 0)
            {
                game.FillRectangle(bchanger1, x1, yf1, x2, y2);
                game.FillRectangle(bchanger2, x2, yf1, x2, y2);
                game.FillRectangle(bchanger3, x3, yf1, x2, y2);
                game.FillRectangle(bchanger4, x4, yf1, x2, y2);
                #region When var "yf1" goes past bottom of the form
                if (yf1 > y)
                {
                    yf1 = 0 - y2;
                    if (pat_assign == pat2)
                    {
                        bchanger1 = bsh_white;
                        bchanger2 = bsh_black;
                        bchanger3 = bsh_white;
                        bchanger4 = bsh_white;
                    }

                    if (pat_assign == pat1)
                    {
                        bchanger1 = bsh_black;
                        bchanger2 = bsh_white;
                        bchanger3 = bsh_white;
                        bchanger4 = bsh_white;
                        pat_select = new int[3] { pat2, pat3, pat4 };
                    }

                    if (pat_assign == pat3)
                    {
                        bchanger1 = bsh_white;
                        bchanger2 = bsh_white;
                        bchanger3 = bsh_black;
                        bchanger4 = bsh_white;
                        pat_select = new int[3] { pat1, pat2, pat4 };
                    }

                    if (pat_assign == pat4)
                    {
                        bchanger1 = bsh_white;
                        bchanger2 = bsh_white;
                        bchanger3 = bsh_white;
                        bchanger4 = bsh_black;
                        pat_select = new int[3] { pat1, pat2, pat3 };
                    }
                    pat_changer.Next(0, pat_select.Length);
                }
                #endregion
            }
        }

And here is the Timer Tick Event Handler

C#

private void tile_timer_Tick(object sender, EventArgs e)
{
    yf1++;
    yf1++;
    yf1++;
    Invalidate();

    //If any black tile goes beyong the bottom off the game screen
    if (yf1 > y)
    {
        if (bchanger1 == bsh_black || bchanger2 == bsh_black || bchanger3 == bsh_black || bchanger4 == bsh_black)
        {
            tile_timer.Stop();
            MessageBox.Show("Game Over");
        }
    }
}

Posted 1-Jun-14 16:12pm

TAOG ASOGA

Updated 2-Jun-14 7:25am

Sergey Alexandrovich Kryukov

v3

Add a Solution

Comments

gggustafson 2-Jun-14 9:29am

All of the code you provided gives a hint at your problem. BUT I need your OnPaint event handler and your timer tick event handler. Also you only need one Invalidate ( ). And get rid of the #regions - it was a Microsoft misstep.

Add the code using the Improve question link, above.

Sergey Alexandrovich Kryukov 2-Jun-14 13:25pm

~~Please don't re-post, it won't help you to get an advice.~~
—SA

gggustafson 2-Jun-14 14:08pm

He's not reposting, he added information that I requested.

Sergey Alexandrovich Kryukov 2-Jun-14 16:02pm

Oh... but it should be done on a page of original question using "Improve question". Why duplicating?
—SA

gggustafson 2-Jun-14 19:59pm

I'm not sure I understand. I asked him to use Improve question and he did. What am I missing?

Sergey Alexandrovich Kryukov 2-Jun-14 20:58pm

Ah... I think there was previous post with the same question from Taog, but it could be removed due to abuse reports. This is what I referred to as "original question". I did not check it when I posted a note. I just re-checked it. In such cases, if OP improves question, there is nothing wrong with re-posting it, of course. I'll remove my comment then.

Thank you and sorry for this little trouble.

--SA

gggustafson 2-Jun-14 14:14pm

How do you wire in the two event handlers? Show me some code as before. What's the difference between tile_timer_Tick and Block_Timer_Tick?

I suggest that you use

protected override void OnPaint ( PaintEventArgs e )

for the declaration of your Paint event handler. No wire up is required. If you have one, after this change, remove it.

TAOG ASOGA 3-Jun-14 14:07pm

Actually, they're the same, I just changed the name from Block_Timer to tile_timer. Sorry sir.

gggustafson 3-Jun-14 14:30pm

tile_timer or tile_timer_Tick? Is within the tile_timer_Tick method the only way that Invalidate is invoked?

Do you wire up the Paint event handler some way. You could do it in the VS designer or in a statement in the class. The easiest was it to use the override of OnPaint.

You appear to be drawing to the form. It that true?

TAOG ASOGA 3-Jun-14 14:32pm

The tile_timer_Tick is the Event for the tile_timer sir. And yes sir I'm drawing on the form.

gggustafson 3-Jun-14 14:33pm

Your Paint handler contains

if (dummy_state == 0)

What is the state of dummy_state and what is its purpose?

TAOG ASOGA 3-Jun-14 14:41pm

um it was a variable I intended earlier when I started the code to use to define the state of the game. I later realized there was an easier way to code the game's state using "if" conditions and I didn't need the variable afterwards. Sorry sir, I'll be removing that variable when I "clean up" the code.

gggustafson 3-Jun-14 14:45pm

Give me some time. I'm going to create your application on my machine. Be back. Might have some questions so stay tuned.

TAOG ASOGA 3-Jun-14 14:46pm

yes sir.

gggustafson 3-Jun-14 15:04pm

In your second Paint event handler, did you change bc1...bc4 to bchanger1...bchanger4

What are the values x1, x2, y2, and yf1?

MOST IMPORTANT: were you aware that windows coordinates are 0,0 at the top left of the form with x-values increasing to the right and y-values increasing DOWNWARD? The y-values are different from those that you are familiar with from the standard cartesian coordinate system.

TAOG ASOGA 3-Jun-14 15:09pm

yes sir, sorry again. The x1, x2, x3, and x4 represent the columns of the tiles. The "yf1" variable is the variable that will bring the row of tiles downward via the tile_timer.

gggustafson 3-Jun-14 15:37pm

what are the initial values of x1, x2, x3, and x4? Do those values change?

What is the initial value of yf1?

Your code contains yf1 = 0 - y2; Is that right? It forces yf1 to have a negative value if y2 is positive. That would put your rectangle above the form.

What are pat1...pat4? what are their initial values? Do the values change?

TAOG ASOGA 3-Jun-14 15:48pm

first off to make things clearer, at the top of the program I declared to variables: int x, y;
Then I gave them this value:
x = ClientRectangle.Width;
y = ClientRectangle.Height;

Then, that's where I declared x1, x2, etc.
The x1, x2, x3, x4 variables represented a different position. And with the variable "x" being the horizontal length of the form
here's the values I gave them:
x1 = 0;
x2 = x / 4;
x3 = (x / 4) * 2; //or just "x2 * 2"
x4 = (x / 4) * 3;

Basically the same thing for y.

The pat1...pat4 represent the patterns.
Those variables I declared them to represent different arrangements of the tiles in a row.
For example like what I included in the question
if (pat_assign == pat2)
{
bchanger1 = bsh_white;
bchanger2 = bsh_black;
bchanger3 = bsh_white;
bchanger4 = bsh_white;
}
Depending on the pattern (or pat variable chosen), if will assign a certain color to each tile. I did this via "if" conditions.

And so to randomize the selection of these patterns, I declared a an array and a random variable and a variable that will assign the randomly chosen pattern variable like this:
int[] pat_select = new int[4]{pat1, pat2, pat3, pat4};

Random pat_changer = new Random();

int pat_assign = pat_select[pat_changer.Next(0, pat_select.Length)];

gggustafson 3-Jun-14 16:18pm

The question I asked was what are pat1...pat4? What are their values?

In the code you provided, pat_select was int [ 3 ] Should it have been int [ 4 ]?

gggustafson 3-Jun-14 15:50pm

When you run your program, does it display "Game done" immediately after one cycle?

TAOG ASOGA 3-Jun-14 15:55pm

yeah, but only if the color of one of the tiles on the row is still black.
My "if" condition for that was this:
if (yf1 > y)
{
if (bc1 == bsh_black || bc2 == bsh_black || bc3 == bsh_black || bc4 == bsh_black)
{
MessageBox.Show("Game Over");
}
}

gggustafson 3-Jun-14 16:08pm

Look at your FillRectangle statements. The x2 that appears in the second, third, and fourth should not be x2 but rather, I think, be x3, x4, and x.

gggustafson 3-Jun-14 16:14pm

Ignore my last.

TAOG ASOGA 3-Jun-14 19:36pm

SIR I FIGURE IT OUT! WOOOOO!! I'm still stitching all the code together. But I found out how to replace the old variable.

gggustafson 3-Jun-14 23:10pm

Congradulations.

ZurdoDev 5-Jun-14 21:28pm

Perhaps you should post something as solution.

gggustafson 6-Jun-14 9:04am

Done

gggustafson 3-Jun-14 9:56am

Are you still interestred in responses to this question?

TAOG ASOGA 3-Jun-14 14:01pm

yes sir

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

gggustafson · Accepted Answer · 2014-06-06T03:04:00

Solution 1

After considerable discussions with OP, he solved his problem.

Posted 6-Jun-14 3:04am

gggustafson

Comments

ZurdoDev 6-Jun-14 9:09am

+5 for sticking with it.