The Weird and The Wonderful

Rajesh Anuhya wrote:

However this is a Small code, which is called by many classes.
 
my
point is why should i declare a extra variable "resultflag", where this method
called 5000+ times in every 10 seconds

Quote:

And I really hope you were intentionally making a point about spurious material with all those emoticons and extraneous formatting, because it makes your post much harder to read.

DECLARE @Month varchar(2), @Year varchar(4), @LastMonth datetime
SET @LastMonth = DateAdd(MONTH, -1, GetDate())
SET @Month = Month(@LastMonth)
SET @Year = Year(@LastMonth)

Nagy Vilmos wrote:

For the C# stuff we had FxCop running in Strict South American Police State mode.

int x; // Value defined in the inner 'for' loop, we cannot determine what it will be yet

int x = 0; // Value defined in the inner 'for' loop. The 0 is a dummy value only to stop warning messages and actually is never correct in the 'for' loop below

Integer x;
if (something()) {
    x = 3;
}

int y = x * 4;

Nagy Vilmos wrote:

variables used within a loop should be defined in the loop

int x;
if(a) x = 5;
// ... some other processing
if(a){
 // something with x, e.g.
 return x;
}

class DontBother : INotifyPropertyChanged {
 public event PropertyChangedEventHandler PropertyChanged;
}

class MainClass {
 List<INotifyPropertyChanged> sources;

 void SomeMethod(){
  sources.Add(new DontBother());
  // Along with some meaningful classes, obviously
 }
}

#pragma warning(suppress: 4700)
int x; // Value defined in the inner 'for' loop, we cannot determine what it will be yet, hence the pragma