Click here to Skip to main content
15,914,488 members
Home / Discussions / C#
   

C#

 
GeneralRe: how to loop through textboxes? Pin
OriginalGriff25-Feb-18 21:47
mveOriginalGriff25-Feb-18 21:47 
GeneralRe: how to loop through textboxes? Pin
Member 1307073625-Feb-18 22:06
Member 1307073625-Feb-18 22:06 
GeneralRe: how to loop through textboxes? Pin
OriginalGriff25-Feb-18 22:20
mveOriginalGriff25-Feb-18 22:20 
GeneralRe: how to loop through textboxes? Pin
BillWoodruff25-Feb-18 23:18
professionalBillWoodruff25-Feb-18 23:18 
GeneralRe: how to loop through textboxes? Pin
BillWoodruff25-Feb-18 23:02
professionalBillWoodruff25-Feb-18 23:02 
GeneralRe: how to loop through textboxes? Pin
Luc Pattyn26-Feb-18 3:09
sitebuilderLuc Pattyn26-Feb-18 3:09 
GeneralRe: how to loop through textboxes? Pin
OriginalGriff26-Feb-18 4:55
mveOriginalGriff26-Feb-18 4:55 
AnswerRe: how to loop through textboxes? Pin
jsc4227-Feb-18 9:42
professionaljsc4227-Feb-18 9:42 
QuestionC# - showing pdf files from mySQL database without using acrobat reader, how? Pin
Member 1365946625-Feb-18 6:38
Member 1365946625-Feb-18 6:38 
AnswerRe: C# - showing pdf files from mySQL database without using acrobat reader, how? Pin
Dave Kreskowiak25-Feb-18 8:03
mveDave Kreskowiak25-Feb-18 8:03 
AnswerRe: C# - showing pdf files from mySQL database without using acrobat reader, how? Pin
Gerry Schmitz25-Feb-18 14:30
mveGerry Schmitz25-Feb-18 14:30 
AnswerRe: C# - showing pdf files from mySQL database without using acrobat reader, how? Pin
sameer54925-Feb-18 22:14
sameer54925-Feb-18 22:14 
AnswerRe: C# - showing pdf files from mySQL database without using acrobat reader, how? Pin
Eddy Vluggen26-Feb-18 0:10
professionalEddy Vluggen26-Feb-18 0:10 
QuestionMessage Removed Pin
23-Feb-18 9:25
Member 1369343023-Feb-18 9:25 
QuestionMemory leak when converting Bitmap to BitmapImage Pin
Leif Simon Goodwin21-Feb-18 23:55
Leif Simon Goodwin21-Feb-18 23:55 
QuestionC# - How to find total rows affected when using EventLogReader (eventLogQuery)? Pin
Shanmuga Sundaram21-Feb-18 19:56
Shanmuga Sundaram21-Feb-18 19:56 
AnswerRe: C# - How to find total rows affected when using EventLogReader (eventLogQuery)? Pin
Gerry Schmitz22-Feb-18 11:53
mveGerry Schmitz22-Feb-18 11:53 
GeneralRe: C# - How to find total rows affected when using EventLogReader (eventLogQuery)? Pin
Shanmuga Sundaram22-Feb-18 19:22
Shanmuga Sundaram22-Feb-18 19:22 
QuestionIs it ok NOT to pass fields into the methods in the same class as parameters? Pin
User9874320-Feb-18 8:59
professionalUser9874320-Feb-18 8:59 
AnswerRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
Richard MacCutchan20-Feb-18 9:05
mveRichard MacCutchan20-Feb-18 9:05 
GeneralRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
User9874320-Feb-18 9:35
professionalUser9874320-Feb-18 9:35 
GeneralRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
Richard MacCutchan20-Feb-18 9:48
mveRichard MacCutchan20-Feb-18 9:48 
SuggestionRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
Richard Deeming20-Feb-18 10:00
mveRichard Deeming20-Feb-18 10:00 
GeneralRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
User9874316-Mar-18 2:50
professionalUser9874316-Mar-18 2:50 
AnswerRe: Is it ok NOT to pass fields into the methods in the same class as parameters? Pin
Bernhard Hiller20-Feb-18 23:26
Bernhard Hiller20-Feb-18 23:26 
There are many things "not so clean" in your code.

Why does that class have a field for the connection string, but otherwise require the connection string to be passed into a public function? Why should a consumer of this class know anything about connection strings?
Also, fields and parameters should "look" differently to avoid confusion of the human reader (I think it is a BUG in Microsoft's specification of scope).

Then there's some UI code also: treeView1_NodeMouseClick. And there is another kind of connection string - now ConnectionString, previously connection_string. Totally confusing.
Also, the else {return;} is not useful.

Obviously, that class is responsible for more than one thing. Hence it needs refactoring to single responsibilities. I am sure that those confusing connection string will be resolved during that refactoring.
Oh sanctissimi Wilhelmus, Theodorus, et Fredericus!

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.