C#

<br />
instance.msmq   = new MessageQueue ( @"FormatName:DIRECT=OS:vircs-d2gs01\private$\InstrumentationQueue" );<br />
MessageQueue.Create ( @".\private$\InstrumentationQueue" );<br />

<br />
instance.msmq   = new MessageQueue ( @"FormatName:DIRECT=OS:vircs-d2gs01\private$\InstrumentationQueue" );<br />
MessageQueue.Create ( @".\private$\InstrumentationQueue" );<br />

mav.northwind wrote:

I guess it would be better to log in the constructor of your exception or add an event handler for unhandled exceptions and perform your logging there.

Regards,
mav

joachimF wrote:

Is it at all possible to kill the error 'Not all code paths return a value'?

joachimF wrote:

I have several classes that need to throw exceptions when some methods are called or the user tries to set some properties

joachimF wrote:

I tried using #pragma, but it seems the compiler thinks this is a real error, and says '161' is an invalid warning number

public interface SomeInterface
{
   void ChangeState();
   int SomeFunction(int arg);
   int SomeMethodWithSideEffect();
   int SomeProperty
   {
      get;
      set;
   }
} // interface SomeInterface

class MessyNullObjectVersion : SomeInterface
{
   public void ChangeState() { throw new ApplicationException("Cannot set properties or change state of null objects."); }
   public int SomeFunction(int arg) { return arg; }
   public int SomeMethodWithSideEffect() { throw new ApplicationException("Cannot set properties or change state of null objects."); }
   public int SomeProperty
   {
      get { return 0; }
      set { throw new ApplicationException("Cannot set properties or change state of null objects."); }
   }
} // class MessyNullObjectVersion

class MaintainableNullObjectVersion : SomeInterface
{
   public void ChangeState() { NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); }
   public int SomeFunction(int arg) { return arg; }
   public int SomeMethodWithSideEffect() { NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); }
   public int SomeProperty
   {
      get { return 0; }
      set { NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); }
   }
} // class MaintainableNullObjectVersion

class NullObjectHelper
{
   public static void Throw_InvalidToCallOrSetOnNullObject()
   {
      throw new ApplicationException("Cannot set properties or change state of null objects.");
   }
} // class NullObjectHelper

// ...Snip for brevity...
public int SomeMethodWithSideEffect() 
{
    throw NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); 
}
// ...Snip for brevity...

 
class NullObjectHelper
{
    public static Exception Throw_InvalidToCallOrSetOnNullObject()
    {
       return new ApplicationException("Cannot set properties or change state of null objects.");
    }
} // class NullObjectHelper

public int SomeMethodWithSideEffect() <br />
{ NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); } 

class NullObjectHelper   {      <br />
public static void Throw_InvalidToCallOrSetOnNullObject()      <br />
{         throw new ApplicationException("Cannot set properties or change state of null objects.");     <br />
 }   <br />
<br />
public static int Throw_InvalidToCallOrSetOnNullObject()      <br />
{         throw new ApplicationException("Cannot set properties or change state of null objects.");     <br />
 }   <br />
} // class NullObjectHelper

public int SomeMethodWithSideEffect() <br />
{ return NullObjectHelper.Throw_InvalidToCallOrSetOnNullObject(); }