C / C++ / MFC

John Simmons / outlaw programmer wrote:

At this point, I'm thinking I'm going to have to write a class derived from COleDateTime to fix it, and then do a global search/replace with the new class name.

John Simmons / outlaw programmer wrote:

it was found on 1525 lines

John Simmons / outlaw programmer wrote:

Before we switched to VS2005/SP1, there were *no* asserts.

Mark Salsbery wrote:

You should use WM_NEXTDLGCTL in a dialog instead of SetFocus().

DavidCrow wrote:

Something is definitely awry here

garfield185 wrote:

Time to come clean...

1. Throw the PreTranslateMessage thing in the trash can. Read this[^].
2. Avoid having your dialog closed on <Enter> and <Esc> by writing appropriate message handlers. Read this[^].
3. Create a CEdit member variable in your dialog class and call CEdit::SetFocus() on that from CDialog::OnInitDialog(). Read this[^].
4. If you explicitly set focus to a control you should return FALSE from OnInitDialog(). The wizard generated comment also clearly states this.

Mark Salsbery wrote:

Heh - wow, the first and last time I recommended using appropriate message handling instead of the over-badly-used PreTranslateMessage() I was ridiculed, tarred, and feathered.

Mark Salsbery wrote:

Bold move

BOOL CSeLlamDlg::PreTranslateMessage(MSG* pMsg) 
{
   if(<code>pMsg->message == WM_KEYDOWN && </code>pMsg->wParam == VK_RETURN) 
   {
      <code>//</code>pMsg->wParam =NULL; <code><-- BAD!!!  Don't change the message and pass it on!!!</code>
      if (Selected==TRUE) 
      {
         OnBtnadd();
      }
      <code>// Add this to eat the return key press</code>
      <code>return TRUE;</code>
   }
 
   return CDialog::PreTranslateMessage(pMsg);
}

garfield185 wrote:

should be needed because when the user presses enter If I don´t do it I close that dialog