ArrayList Problem - Windows Forms Discussion Boards

Re: How to Improve the performance of a database application [modified]

Uma Kameswari22-Dec-08 18:38

22-Dec-08 18:38

I tried moving the entire logic to server side but still did not find any improvement. The problem is with the huge data being handled in a loop. I need a way to eliminate the loop. If I have to redo the loop with a select statement as we did in the previous case I am having some problem. I am taking the value of 2 fields based on the field value. I am giving the code below. Let me know if this can be handled in a select query directly.I think we can use switch case in the select statement but I am not sure.

SELECT JRNENTRY,trxdate,trxsorce,USWHPSTD,ortrxsrc,orgntsrc,orctrnum,debitamt,
crdtamnt,Dex_row_id,actindx,
(select rtrim(actnumbr_1) + '-'+rtrim(actnumbr_2) + '-'+
rtrim(actnumbr_3) + '-' + rtrim(actnumbr_4) + '-' + 
rtrim(actnumbr_5) + '-' + 
rtrim(actnumbr_6) + '-' + rtrim(actnumbr_7) from gl00100 g1 
where g1.actindx = g.actindx) 'account',
 origseqnum FROM GL20000 g WHERE  trxdate between convert(datetime,'01/04/2007',103) and 
convert(datetime,'31/03/2008',103) and 
actindx in (4818,25,3189) and series <> 2 
and correspondingunit <> 1

the above query gets me a record set.
in the loop for the above record set i am taking value of few fields for insertion or updation based on the value of the field. the logic is as below

for (int i = 0; i < ds.Tables["InGL"].Rows.Count; i++)
{
    strOrgnTrxSorce = ds.Tables["InGL"].Rows[i]["orgntsrc"].ToString();
    strOrgnDocNo = ds.Tables["InGL"].Rows[i]["orctrnum"].ToString();
    strOrTrxSrc = ds.Tables["InGL"].Rows[i]["ortrxsrc"].ToString();
strSource = strOrgnTrxSorce.Trim();
   if (strOrgnTrxSorce.Trim() == "")
       strSource = strOrTrxSrc;
select count(*) from gl_sl_cmpr where sopno='" + strOrgnDocNo + "' 
and actindex ='" + strActIndex + "' and trxsorce='" + strSource + "'"

}

based on the "select count(*) ... " query count I will either insert or update a table.
Now my problem is do I have any way of including the above logic in a single sql statement.

Also you suggested me to use loops if necessary with in stored procedure. I tried using cursor in stored procedure by moving the logic from .net but still it is taking the same time.

modified on Tuesday, December 23, 2008 12:48 AM

Re: How to Improve the performance of a database application

Uma Kameswari23-Dec-08 0:04

Uma Kameswari

23-Dec-08 0:04

I modified the loop from the application as follows but I have a problem here I cannot give insert/update command in case.Is there any way to solve this. If there exists an alternative solution then it will help a lot. The queries are working correctly I tested them. The following is the code

select  
case (select count(*) from test a 
      where a.trxsorce = case rtrim(b.orgntsrc) 
                         when '' then   
                              b.ortrxsrc        
                         else b.orgntsrc 
                         end                 
and a.act=b.actindx and a.sopno = b.orctrnum) 
when 0 then 
insert into test  
      (gltrxdate,jrnentry,source,glact,glactindex,uswhpstd,ortrxsrc,
       orgctrnum,gldr,glcr,gldexrowid,status)
       select trxdate,jrnentry,trxsorce,account,actindx,uswhpstd,orgntsrc,
           orctrnum,debitamt,crdtamnt,dex_row_id,2 
       from gl20000 where dex_row_id=b.dex_row_id

when 1 then 
update test set 
     gltrxdate = b.trxdate,jrnentry = b.jrnentry,
     source = b.trxsorce,glact = b.account,
     glactindex = b.actindx,uswhpstd = b.uswhpstd,
     ortrxsrc = b.orgntsrc,orgctrnum = b.orctrnum,
     gldr = b.debitamt,
     glcr = b.crdtamnt,gldexrowid = b.dex_row_id,status =7
where sopno = b.orctrnum and actindx = b.actindx and 
     trxsorce = b.trxsorce

else 
insert into test 
   (gltrxdate,jrnentry,source,glact,glactindex,uswhpstd,ortrxsrc,
    orgctrnum,gldr,glcr,gldexrowid,status)
    select trxdate,jrnentry,trxsorce,account,actindx,uswhpstd,orgntsrc,
    orctrnum,debitamt,crdtamnt,dex_row_id,7 
    from gl20000 where dex_row_id=b.dex_row_id

end 
from gl20000 b where 
trxdate between convert(datetime,'01/04/2007',103) and 
convert(datetime,'30/04/2007',103) and actindx in 
(select actindx from gl00100 where actnumbr_6=1300) and 
series <> 2 and correspondingunit <> 1

Re: How to Improve the performance of a database application

Wendelius23-Dec-08 3:23

Wendelius

23-Dec-08 3:23

Quickly looking you just have to split this to two separate statements: One update and one insert.

The need to optimize rises from a bad design.My articles[^]

Re: How to Improve the performance of a database application

Uma Kameswari23-Dec-08 18:05

Uma Kameswari

23-Dec-08 18:05

How to split them. The insert or Update statement is not allowed in case statement.

Re: How to Improve the performance of a database application

Wendelius28-Dec-08 10:35

Wendelius

28-Dec-08 10:35

Uma Kameswari wrote:
How to split them. The insert or Update statement is not allowed in case statement

Don't use single statement. Create a different insert statement and different update statement and execute both separately. Instead of using case in select, use where conditions, like:

insert into table (columns)
select columns
from anothertable
where ConditionsToBeMet

and

update table 
set columns
where ConditionsToBeMet

Just make the conditions so that they define the logic you defined in case statement.

The need to optimize rises from a bad design.My articles[^]

Visual studio addin

Fadi Yoosuf14-Dec-08 16:11

Fadi Yoosuf

14-Dec-08 16:11

Will it be feasible to create and add in for visual studio which can draw with a sketch on the coding window.

Re: Visual studio addin

Lev Danielyan15-Dec-08 19:55

Lev Danielyan

15-Dec-08 19:55

Check out this article http://www.codeproject.com/KB/macros/LineCounterAddin.aspx[^]

Regards,
Lev

ArrayList Problem

bapu288912-Dec-08 8:31

bapu2889

12-Dec-08 8:31

Hello

I have this small but confusing exercise and what i want to do is when form loads it displays all the widgets in one listbox(small and big) and in second one I just want to display small widgets so could you please help me with this

code is as bellow

Imports System.Collections.Generic
Imports System.Text
Imports System.Collections

Public Class Form1


    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
    
        Dim colBoxesOfWidgets As New ArrayList()
        colBoxesOfWidgets.Add(New BoxOfWidgets("Cardboard"))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Blue Widget", 12))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Red Widget", 15))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Silver Widget", 6))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Green Widget", 52))

        colBoxesOfWidgets.Add(New BoxOfWidgets("Metal"))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Gold Widget", 9))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Orange Widget", 115))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Pink Widget", 1))

        colBoxesOfWidgets.Add(New BoxOfWidgets("Metel"))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Grey Widget", 12))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Black Widget", 15))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The White Widget", 19))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Brown Widget", 60))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Peach Widget", 16))

        Call GetRidOfTheSmallWidgets(colBoxesOfWidgets)



    End Sub

    Public Function GetRidOfTheSmallWidgets(ByVal colBoxesOfWidgets As ArrayList) As ArrayList

       For J As Integer = 0 To colBoxesOfWidgets.Count - 1
          ListBox1.Items.Add(DirectCast(colBoxesOfWidgets(J), _
          BoxOfWidgets).colWidgets.Add(J))

       Next      :confused:
     
       Return (colBoxesOfWidgets)

    End Function

End Class

Class BoxOfWidgets
    Public boxType As String
    Public colWidgets As ArrayList

    Public Sub New(ByVal newBoxType As String)
        boxType = newBoxType
        colWidgets = New ArrayList()
    End Sub
End Class

Class Widget
    Public name As String
    Public length As Single

    Public Sub New(ByVal newName As String, ByVal newLength As Single)
        Me.name = newName
        Me.length = newLength
    End Sub
End Class

and problem with this is it loads the items in to listbox but only numbers I mean how many widgets are there in each boxof widgets but i want to display all the widgets from all boxes

waiting for your kind help

Not able to retain DataGridViewComboBox Cell's selected item value

Member 62119111-Dec-08 18:38

Member 621191

11-Dec-08 18:38

Hi,

I have a ComboBox Column in DataGridView and also I use Cell Formatting event to change the Images dynamically in the DataGridViewImage Column based on business validations.

I am not able to retain the selected item value in the Combobox cell, it is disappearing because of Cell Formatting event always fires and re-instantiates the combo cell to default value.

If I disable Cell Formatting event code, I can see the value is retained in the combobox cell and it works

Please let me how to solve this issue, because I have to use Cell Formatting evetn for various conditions, So I can not disable the code.

give an idea or code sample to retain selected values in the combo cells on usage cell formatting event

Thank you

Shyam Sundar

Simple custom control repaint problem

TheRedEye10-Dec-08 22:05

TheRedEye

10-Dec-08 22:05

I've done a simple custom label in .net 2.0 that allows a border color to be set. The problem is I can't get the control to repaint if another form is dragged over the control. I've tried the SetStyle() method and it doesn't seem to help.

   public partial class BorderLabel: Label
    {
        public BorderLabel()
        {
            InitializeComponent();
            this.SetStyle(ControlStyles.AllPaintingInWmPaint | ControlStyles.UserPaint | ControlStyles.OptimizedDoubleBuffer, true); // this doesn't help        
        }
                  
        private Color _borderColor = Color.Black;
        public Color BorderColor
        {
            get { return _borderColor; }
            set
            {
                _borderColor = value;
                Invalidate();
            }
        }
        protected override void OnPaint(PaintEventArgs e)
        {
            base.OnPaint(e);
            int borderWidth = 1;
            ControlPaint.DrawBorder(e.Graphics, e.ClipRectangle, _borderColor,
                      borderWidth, ButtonBorderStyle.Solid, _borderColor, borderWidth,
                      ButtonBorderStyle.Solid, _borderColor, borderWidth, ButtonBorderStyle.Solid,
                      _borderColor, borderWidth, ButtonBorderStyle.Solid);
        }
}

What other events should I be overriding to cause the control to repaint when a form is dragged over the control?

Re: Simple custom control repaint problem

Dave Kreskowiak11-Dec-08 2:04

Dave Kreskowiak

11-Dec-08 2:04

Change your ControlPaint to "e.Graphics":

protected override void OnPaint(PaintEventArgs e)
{
    base.OnPaint(e);
    int borderWidth = 1;
    e.Graphics.DrawBorder(e.Graphics, e.ClipRectangle, _borderColor,
                      borderWidth, ButtonBorderStyle.Solid, _borderColor, borderWidth,
                      ButtonBorderStyle.Solid, _borderColor, borderWidth, ButtonBorderStyle.Solid,
                      _borderColor, borderWidth, ButtonBorderStyle.Solid);
}

Use the Graphics object you are given in the event arguments, not your own.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak
Microsoft MVP
Visual Developer - Visual Basic
2006, 2007, 2008

Re: Simple custom control repaint problem

TheRedEye11-Dec-08 4:05

TheRedEye

11-Dec-08 4:05

Thanks but what fixed it was not using the e.ClipRectangle, but using the ClientRectangle object instead.

Re: Simple custom control repaint problem

Dave Kreskowiak11-Dec-08 4:42

Dave Kreskowiak

11-Dec-08 4:42

You know, I didn't even read into the entire line. I just looked at the beginning of it and said "wait a minute...". I was runnig short on time this morning. D'Oh! | :doh:

A guide to posting questions on CodeProject[^]

Dave Kreskowiak
Microsoft MVP
Visual Developer - Visual Basic
2006, 2007, 2008

how to change language dependent datetime picker dynamically in .net window forms

arunmca.r10-Dec-08 21:43

arunmca.r

10-Dec-08 21:43

dear friends,

i need your help,Now i am creating billingual Apllication how to change the date time in english and arabic for run time

Thanx
R.Arun

Re: how to change language dependent datetime picker dynamically in .net window forms

Mycroft Holmes11-Dec-08 20:37

Mycroft Holmes

11-Dec-08 20:37

excellent, look into resource files.

Never underestimate the power of human stupidity
RAH

Re: how to change language dependent datetime picker dynamically in .net window forms

arunmca.r14-Dec-08 17:31

arunmca.r

14-Dec-08 17:31

Dear Friends,

Here I Search All resource file Posiblities Change Font in to Arabic it is not working.Any other ideas about that please share with me.
Thanks
Arun.R

arraylist problem

bapu288910-Dec-08 9:12

bapu2889

10-Dec-08 9:12

Hello

This is one exercise in OOP lesson ,but still I am bit confuse how to get rid of small widgets, and what I want to do is when form loads it displays small widgets(<= 20) in one listbox and and rest in second listox, any help, In Public Function GetRidOfTheSmallWidgets I have put loop but it's only displays 0,1,2 so how can i add small widgets in one listbox and big ones in second listbox

Imports System.Collections.Generic
Imports System.Text
Imports System.Collections

Public Class Form1


    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
    
        Dim colBoxesOfWidgets As New ArrayList()
        colBoxesOfWidgets.Add(New BoxOfWidgets("Cardboard"))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Blue Widget", 12))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Red Widget", 15))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Silver Widget", 6))
        DirectCast(colBoxesOfWidgets(0), BoxOfWidgets).colWidgets.Add(New Widget("The Green Widget", 52))

        colBoxesOfWidgets.Add(New BoxOfWidgets("Metal"))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Gold Widget", 9))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Orange Widget", 115))
        DirectCast(colBoxesOfWidgets(1), BoxOfWidgets).colWidgets.Add(New Widget("The Pink Widget", 1))

        colBoxesOfWidgets.Add(New BoxOfWidgets("Metel"))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Grey Widget", 12))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Black Widget", 15))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The White Widget", 19))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Brown Widget", 60))
        DirectCast(colBoxesOfWidgets(2), BoxOfWidgets).colWidgets.Add(New Widget("The Peach Widget", 16))

        Call GetRidOfTheSmallWidgets(colBoxesOfWidgets)



    End Sub

    Public Function GetRidOfTheSmallWidgets(ByVal colBoxesOfWidgets As ArrayList) As ArrayList

       For I As Integer = 0 To colBoxesOfWidgets.Count - 1

            lstWidgets.Items.Add(I).ToString()

        Next
        Return (colBoxesOfWidgets)

    End Function

End Class

Class BoxOfWidgets
    Public boxType As String
    Public colWidgets As ArrayList

    Public Sub New(ByVal newBoxType As String)
        boxType = newBoxType
        colWidgets = New ArrayList()
    End Sub
End Class

Class Widget
    Public name As String
    Public length As Single

    Public Sub New(ByVal newName As String, ByVal newLength As Single)
        Me.name = newName
        Me.length = newLength
    End Sub
End Class

Re: arraylist problem

Ben Fair10-Dec-08 10:05

Ben Fair

10-Dec-08 10:05

You are dealing with an ArrayList that contains BoxOfWidgets instances. The ArrayList is populated with only 3 BoxOfWidgets instances: Cardboard, Metal and Metel. Each BoxOfWidgets instance has it's own internal ArrayList named colWidgets. Perhaps your intention is to iterate over the internal collections of each BoxOfWidgets:

For I As Integer = 0 To colBoxesOfWidgets.Count - 1
    For J As Integer = 0 To DirectCast(colBoxesOfWidgets[I], BoxOfWidgets).colWidgets.Count - 1
        lastWidgets.Items.Add(J).ToString()
    Next
Next

Last, I'd also recommend using the Generic List rather than an ArrayList as it will perform better.

Keep It Simple Stupid! (KISS)

Re: arraylist problem

bapu288910-Dec-08 19:57

bapu2889

10-Dec-08 19:57

hello sir

Yes it works but it only displays o,1,2,3 numbers in listbox not name or length of widgets

waiting for your kind rep.

Re: arraylist problem

Ben Fair11-Dec-08 3:13

Ben Fair

11-Dec-08 3:13

The reason you only see numbers in the ListBox is because the following loop is adding the integer I to the list box on each pass:

For I As Integer = 0 To colBoxesOfWidgets.Count - 1
    lstWidgets.Items.Add(I).ToString()
Next

So, you probably want something like this:

For I As Integer = 0 To colBoxesOfWidgets.Count - 1
    lstWidgets.Items.Add((DirectCast(colBoxesOfWidgets(I), BoxOfWidgets).boxType)
Next

Keep It Simple Stupid! (KISS)

Re: arraylist problem

bapu288911-Dec-08 9:43

bapu2889

11-Dec-08 9:43

Hello sir

thanks for your rep.

yes it works but still i am not getting all the lists for widgets like it shows box of widgets but it's not showing what's in there in each box so I have tried this and it shows how many widgets are there in each box but not name of that widgets i am getting there but still need to do some thing little to get there

so this is what i have done

For J As Integer = 0 To colBoxesOfWidgets.Count - 1
          ListBox1.Items.Add(DirectCast(colBoxesOfWidgets(J), _
          BoxOfWidgets).colWidgets.Add(J))

      Next

so i think i need to get class widget to get name and length for each widgets but i am lost Confused | :confused:

waiting for your kind rep.

have a nice day

Accessing ListBox from multiple threads

Mr.Brainley8-Dec-08 5:39

Mr.Brainley

8-Dec-08 5:39

I have a multithreaded application, and want to access a ListBox from multiple threads. However, if i add an item to the ListBox from a thread different from the one it was created in, the changes are only shown, once i trigger a refresh from the creation thread. Is there any way around that ?

Re: Accessing ListBox from multiple threads

Giorgi Dalakishvili8-Dec-08 6:01

Giorgi Dalakishvili

8-Dec-08 6:01