Click here to Skip to main content
15,907,392 members
Home / Discussions / WPF
   

WPF

 
GeneralRe: MVVM FolderBrowserDialog Pin
eddieangel16-Nov-10 6:05
eddieangel16-Nov-10 6:05 
GeneralRe: MVVM FolderBrowserDialog Pin
SledgeHammer0116-Nov-10 7:04
SledgeHammer0116-Nov-10 7:04 
GeneralRe: MVVM FolderBrowserDialog Pin
eddieangel16-Nov-10 7:11
eddieangel16-Nov-10 7:11 
GeneralRe: MVVM FolderBrowserDialog Pin
SledgeHammer0116-Nov-10 9:09
SledgeHammer0116-Nov-10 9:09 
AnswerRe: MVVM FolderBrowserDialog Pin
Kevin Marois17-Nov-10 5:24
professionalKevin Marois17-Nov-10 5:24 
GeneralRe: MVVM FolderBrowserDialog Pin
SledgeHammer0117-Nov-10 9:47
SledgeHammer0117-Nov-10 9:47 
GeneralRe: MVVM FolderBrowserDialog Pin
Kevin Marois17-Nov-10 11:14
professionalKevin Marois17-Nov-10 11:14 
GeneralRe: MVVM FolderBrowserDialog Pin
SledgeHammer0117-Nov-10 12:31
SledgeHammer0117-Nov-10 12:31 
I did read what you wrote. Did you? Did you read what I wrote?

You gave the OP a PromptForFile method that calls fileOpen.ShowDialog() directly.

It doesn't matter what class that method lives in, calling it from the **VM** is a violation of MVVM -- because it pops up a modal dialog thats not mockable.

Had you used a ServiceLocator like everybody else in this thread suggested, that method would be fine and could even live in your VM.

Are you somehow magically subclassing OpenFileDialog?

MVVM is more then just splitting your CodeBehind into another class. Its also about making your ViewModel unit testable. Popping up a modal dialog (like the OpenFileDialog or MessageBox) without it being replaceable is not allowed.
GeneralRe: MVVM FolderBrowserDialog Pin
Pete O'Hanlon17-Nov-10 10:00
mvePete O'Hanlon17-Nov-10 10:00 
GeneralRe: MVVM FolderBrowserDialog Pin
_Maxxx_17-Nov-10 16:11
professional_Maxxx_17-Nov-10 16:11 
GeneralRe: MVVM FolderBrowserDialog Pin
Pete O'Hanlon17-Nov-10 21:50
mvePete O'Hanlon17-Nov-10 21:50 
QuestionDataGrid - merging cells Pin
urinspiration15-Nov-10 7:41
urinspiration15-Nov-10 7:41 
QuestionWPF Style Question Pin
Kevin Marois15-Nov-10 7:08
professionalKevin Marois15-Nov-10 7:08 
AnswerRe: WPF Style Question Pin
#realJSOP15-Nov-10 8:03
professional#realJSOP15-Nov-10 8:03 
GeneralRe: WPF Style Question Pin
Kevin Marois15-Nov-10 8:05
professionalKevin Marois15-Nov-10 8:05 
GeneralRe: WPF Style Question [modified] Pin
SledgeHammer0115-Nov-10 8:55
SledgeHammer0115-Nov-10 8:55 
GeneralRe: WPF Style Question Pin
Kevin Marois15-Nov-10 12:13
professionalKevin Marois15-Nov-10 12:13 
GeneralRe: WPF Style Question Pin
SledgeHammer0115-Nov-10 13:29
SledgeHammer0115-Nov-10 13:29 
GeneralRe: WPF Style Question Pin
Kevin Marois16-Nov-10 4:37
professionalKevin Marois16-Nov-10 4:37 
GeneralRe: WPF Style Question Pin
SledgeHammer0116-Nov-10 14:06
SledgeHammer0116-Nov-10 14:06 
GeneralRe: WPF Style Question Pin
SledgeHammer0116-Nov-10 14:10
SledgeHammer0116-Nov-10 14:10 
Questionexecute code on Server-side - Silverlight Pin
jadughar14-Nov-10 19:40
jadughar14-Nov-10 19:40 
AnswerRe: execute code on Server-side - Silverlight Pin
Vimalsoft(Pty) Ltd14-Nov-10 20:10
professionalVimalsoft(Pty) Ltd14-Nov-10 20:10 
AnswerRe: execute code on Server-side - Silverlight Pin
Abhinav S14-Nov-10 20:40
Abhinav S14-Nov-10 20:40 
GeneralRe: execute code on Server-side - Silverlight Pin
jadughar14-Nov-10 21:07
jadughar14-Nov-10 21:07 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.