Welcome to the Lounge

honey the codewitch wrote:

The code is evil. It's absolutely terrible to read, almost as if they were *trying* to hide intent.

// ====================================================================
// USELESS SHIT LEFT OVER FROM THE ORIGINAL IMPLEMENTATION
// ====================================================================

Gary R. Wheeler wrote:

I am now responsible for a piece of code that's been part of our business for over thirty years...Function prototypes weren't used. Header files didn't define the functions or data in the corresponding .C source file. There were...

Gary R. Wheeler wrote:

a group of #define's he'd added before #include <windows.h> which changed the definition of a number of values in the Windows headers which his comment (one of the few) claimed "Microsoft got wrong".

jschell wrote:

Could not speak specifically to that but as I recall there were a lot of problems with the early Microsoft C++. I know for a fact that for years after the ANSI C++ spec was released the Microsoft scored very poorly on implementing it. That was back when people could actually post comparisons of software without getting sued.

Quote:

I'm poring over C code right now - C really isn't that much better, but fortunately you can do less with it. The code is evil. It's absolutely terrible to read, almost as if they were *trying* to hide intent.

charlieg wrote:

but to be honest, that can be done in any language.

char* code = "\xCC\xFF...";
typedef int* myfunct(int i)
int result = (myfunct)(code)(45);

/* Do not change this code or ponies will cry */

honey the codewitch wrote:

but would it kill people to write readable code, or at least comment it with something *helpful*?

if(pin_d1>31) {
    b |= (((pins_h>>((pin_d1-32)&31))&1)<<1);
} else if(pin_d1>-1) {
    b |= (((pins_l>>(pin_d1))&1)<<1);
}
if(pin_d2>31) {
    b |= (((pins_h>>((pin_d2-32)&31))&1)<<2);
} else if(pin_d2>-1) {
    b |= (((pins_l>>(pin_d2))&1)<<2);
}
if(pin_d3>31) {
    b |= (((pins_h>>((pin_d3-32)&31))&1)<<3);
} else if(pin_d3>-1) {
    b |= (((pins_l>>(pin_d3))&1)<<3);
}
if(pin_d4>31) {
    b |= (((pins_h>>((pin_d4-32)&31))&1)<<4);
} else if(pin_d4>-1) {
    b |= (((pins_l>>((pin_d4)&31))&1)<<4);
}
if(pin_d5>31) {
    b |= (((pins_h>>((pin_d5-32)&31))&1)<<5);
} else if(pin_d5>-1) {
    b |= (((pins_l>>(pin_d5))&1)<<5);
}
if(pin_d6>31) {
    b |= (((pins_h>>((pin_d6-32)&31))&1)<<6);
} else if(pin_d6>-1) {
    b |= (((pins_l>>(pin_d6))&1)<<6);
}
if(pin_d7>31) {
    b |= (((pins_h>>((pin_d7-32)&31))&1)<<7);
} else if(pin_d7>-1) {
    b |= (((pins_l>>(pin_d7))&1)<<7);
}