|
im trying convert this Trading view code to C#
l20d = low < ta.lowest(low,20)[1]
|
|
|
|
|
I have a lines of data being written to a serial port. This data is in the following form
50 100 150 200 250 300 300 136 55 110 175 225 268 364 398 193
I am trying to make a C# application which would continously update 16 text boxes with these 16 values which are seperated by a tab. My current code just writes some garbage to the first textbox then the application closes. WHy?
void DataReceivedHandler(object sender, SerialDataReceivedEventArgs e)
{
string dataLine = serialPort1.ReadLine();
if (dataLine == null || dataLine.Trim().Length == 0)
{
return;
}
string[] dataValues = dataLine.Split('\t');
textBox2.Text = dataValues[0];
textBox3.Text = dataValues[1];
textBox4.Text = dataValues[2];
textBox5.Text = dataValues[3];
textBox6.Text = dataValues[4];
textBox7.Text = dataValues[5];
textBox8.Text = dataValues[6];
textBox9.Text = dataValues[7];
textBox10.Text = dataValues[8];
textBox11.Text = dataValues[9];
textBox12.Text = dataValues[10];
textBox13.Text = dataValues[11];
textBox14.Text = dataValues[12];
textBox15.Text = dataValues[13];
textBox16.Text = dataValues[14];
textBox17.Text = dataValues[15];
}
private void button3_Click(object sender, EventArgs e)
{
try
{
if (serialPort1.IsOpen)
{
serialPort1.DataReceived += DataReceivedHandler;
}
else
{
MessageBox.Show("Error : Port needs to be open or wrong port selected!");
}
}
catch (Exception ex)
{
MessageBox.Show(ex.Message, "Message", MessageBoxButtons.OK, MessageBoxIcon.Error);
}
}
|
|
|
|
|
And didn't you DEBUG your code? 
|
|
|
|
|
Mismatched baud rate? Start bit?
And you receive garbage, so it is likely you do not have 15 tab characters decoded - so dataValues[x] will throw an exception once x is larger than the array length.
But as mentioned you already have a tool that will tell you that in seconds: the debugger.
|
|
|
|
|
You're expecting a certain length, but aren't checking how much you're actually reading; just that it is longer than "nothing".
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
|
|
|
|
|
Kshitij Bali wrote: then the application closes. WHy?
Besides what the other responses said...
You need a try/catch in DataReceivedHandler.
I suspect that would tell you why the application is exiting.
|
|
|
|
|
private bool isFirstLine = true;
void DataReceivedHandler(object sender, SerialDataReceivedEventArgs e)
{
try
{
string dataLine = serialPort1.ReadLine();
if (dataLine == null || dataLine.Trim().Length == 0)
{
return;
}
if (isFirstLine)
{
isFirstLine = false;
return;
}
string[] dataValues = dataLine.Split('\t');
this.Invoke((MethodInvoker)delegate
{
textBox2.Text = dataValues[0];
textBox3.Text = dataValues[1];
textBox4.Text = dataValues[2];
textBox5.Text = dataValues[3];
textBox6.Text = dataValues[4];
textBox7.Text = dataValues[5];
textBox8.Text = dataValues[6];
textBox9.Text = dataValues[7];
textBox10.Text = dataValues[8];
textBox11.Text = dataValues[9];
textBox12.Text = dataValues[10];
textBox13.Text = dataValues[11];
textBox14.Text = dataValues[12];
textBox15.Text = dataValues[13];
textBox16.Text = dataValues[14];
textBox17.Text = dataValues[15];
});
}
catch (Exception ex)
{
MessageBox.Show(ex.Message, "Message", MessageBoxButtons.OK, MessageBoxIcon.Error);
}
}
private void ClearTextBoxes()
{
textBox2.Text = "";
textBox3.Text = "";
textBox4.Text = "";
textBox5.Text = "";
textBox6.Text = "";
textBox7.Text = "";
textBox8.Text = "";
textBox9.Text = "";
textBox10.Text = "";
textBox11.Text = "";
textBox12.Text = "";
textBox13.Text = "";
textBox14.Text = "";
textBox15.Text = "";
textBox16.Text = "";
textBox17.Text = "";
}
private bool isReadingData = false;
private void button3_Click(object sender, EventArgs e)
{
try
{
if (serialPort1.IsOpen)
{
if (!isReadingData)
{
serialPort1.WriteLine("1");
serialPort1.DataReceived += DataReceivedHandler;
isReadingData = true;
button3.Text = "STOP";
button1.Enabled = false;
button1.Visible = false;
}
else
{
serialPort1.WriteLine("0");
serialPort1.DataReceived -= DataReceivedHandler;
isReadingData = false;
button3.Text = "START";
button1.Enabled = true;
button1.Visible = true;
ClearTextBoxes();
}
}
else
{
MessageBox.Show("Error : Port needs to be open or wrong port selected!");
}
}
catch (Exception ex)
{
MessageBox.Show(ex.Message, "Message", MessageBoxButtons.OK, MessageBoxIcon.Error);
}
}
private void button1_Click(object sender, EventArgs e)
{
if(serialPort1.IsOpen)
{
PortClosing();
button1.Text = "Open";
ClearTextBoxes();
button3.Visible = false;
}
else
{
PortOpening();
button1.Text = "Close";
button3.Visible = true;
}
}
modified 21-Nov-23 2:41am.
|
|
|
|
|
As suggested, you need to learn how to debug the code by using the debugger.
That will allow you to step through the lines.
Kshitij Bali wrote: index is out of bounds of the array
I think this was already suggested....
This is accessing an array 'dataValues[15]'
The error occurs when the array is NOT that big.
You are assuming it is that size. It isn't. So you need to check. As suggested the results are probably coming in pieces and not all at once. Or only some is coming.
|
|
|
|
|
I'm trying to populate a combobox with a column in a SQLite database table. Im using an Absolute path in my connection string but Im getting an Error that the table doesn't exist. Ive read through other posts and still cant resolve the problem. Here is my code.
public Form1()
{
InitializeComponent();
if (File.Exists(@"R:\TEOP\Tracker\Tracker.db"))
{
SQLiteConnection conn;
conn = new SQLiteConnection("Data Source=R:\\TEOP\\Tracker\\Tracker.db,version=3;");
conn.Open();
SQLiteCommand cmd;
cmd = conn.CreateCommand();
cmd.CommandText = @"SELECT IncidentName FROM Incident;";
var dr = cmd.ExecuteReader();
while (dr.Read())
{
IncidentCombo.Items.Add(dr["IncidentName"]);
}
}
}
Ive checked permissions and path. My query works in the database browser.
|
|
|
|
|
In problem posts like this, always copy'n'paste the exact error message.
If the message indeed says your table doesn't exist, it has nothing to do with the connection string. It's telling you don't have a table called 'Incident' in your database. Check the spelling of the table name in your query and carefully compare to the table name in the database.
|
|
|
|
|
NOTE: DISCLAIMER: I have no experience with SQLite! This is just a shot in the dark from an ignorant non-expert:
I tried to look up examples of SQL use, and saw them use a semicolon rather than a comma before 'version=3;'
I also saw that opening a non-existing database will created one by the given name.
So, if the entire string 'R:\\TEOP\\Tracker\\Tracker.db,version=3' is take as a database name, then you are opening a new, empty database, which obviously doesn't have an 'Incident' table.
(I must admit that I am surprised if a database can be named R:\\TEOP\\Tracker\\Tracker.db,version=3, so this may be a completely wrong track to follow!)
|
|
|
|
|
Thank you that was the problem ....A typing error replacing the "," with a ";" was the problem. Syntax is a killer at times!....lol
|
|
|
|
|
Nice catch. I missed that one.
|
|
|
|
|
Just seen this example of C# 12 on Reddit:
public double GPA => grades switch
{
[] => 4.0,
[var grade] => grade,
[.. var all] => all.Average()
}; Seems innocuous enough, but there is a subtle problem: if the array contains more than one element, the property will allocate a copy of the entire array simply to pass to the Average method.
SharpLab[^]:
public double GPA
{
get
{
double[] array = <grades>P;
if (array != null)
{
int num = array.Length;
if (num != 0)
{
if (num == 1)
{
return array[0];
}
double[] subArray = RuntimeHelpers.GetSubArray(array, new Range(new Index(0), new Index(0, true)));
return Enumerable.Average(subArray);
}
return 4.0;
}
<PrivateImplementationDetails>.ThrowSwitchExpressionException(array);
double result = default(double);
return result;
}
} NB: The RuntimeHelpers.GetSubArray method[^] has no check to see if it's returning the entire array; it always creates a copy.
It's simple enough to fix:
public double GPA => grades switch
{
[] => 4.0,
[var grade] => grade,
[..] all => all.Average()
}; SharpLab[^]
public double GPA
{
get
{
double[] array = <grades>P;
if (array != null)
{
int num = array.Length;
if (num != 0)
{
if (num == 1)
{
return array[0];
}
return Enumerable.Average(array);
}
return 4.0;
}
<PrivateImplementationDetails>.ThrowSwitchExpressionException(array);
double result = default(double);
return result;
}
} But good luck spotting the difference in a code review, or explaining to anyone who hasn't spent time spelunking the BCL source repository why [..] all is better than [.. var all]! 
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
I think I'll stick with C, or maybe go back to COBOL. 
|
|
|
|
|
I have seen two different developers use a foreach() on a hash. To do a look up. So it turns the hash into a list of key-value pairs then searches that list. Naturally completely obliviating the point of the hash.
Surprised me so much that now it is something I explicitly look for.
|
|
|
|
|
what should i do now when i run the program and it has this error : "
Exception from HRESULT: 0x800A03EC
"
|
|
|
|
|
You could start by asking Google what the error code means. Then go back to your code, to the line where the error is produced, and try to work out what is wrong with your code or the data it is working on.
|
|
|
|
|
Your error seems to be excel related, you did however posted a one liner and expected the world to mind read what you meant.
I googled the error and it popped up with multiple solutions - Save me from this error[^]
and by selecting the first solution on SO, easy to fix - My error is fixed![^]
|
|
|
|
|
I am new to asp.net core. I have a form which is generated dynamically. I want the validation error message to be "The value must be numeric" instead I get "The value 'a' is invalid" when I submit the form.
Here is my View Model:
[RegularExpression("^[0-9]*$", ErrorMessage = "The value must be numeric")]
public List<int> Units_Service { get; set; }
Here is my form code:
for (int i = 0; i < Model.Workload_Category_Name.Count; i++)
{
<div class="row">
<div class="col-md-3">
<b></u>@Html.DisplayFor(model => model.Workload_Category_Name[i])</u> </b>
</div>
<div class="col-md-4">
@Html.TextBoxFor(model => model.Units_Service[i], new { style = "width: 15%", MaskedTextBox = "9999" })
@Html.ValidationMessageFor(model => model.Units_Service[i])
</div>
</div>
}
Despite the fact, I have put the custom error message in my View Model as shown above, I keep getting the default message "The value '' is invalid". Please what is the solution to this kind of scenario ?
|
|
|
|
|
The problem is, you're validating the Units_Service property, not the individual items within it.
And applying a regular expression validation to anything other than a string property makes no sense.
Probably the simplest option would be to create a viewmodel for each item in the list - for example:
public class UnitsServiceViewModel
{
[Required(ErrorMessage = "You must enter a value.")]
[RegularExpression("^[0-9]*$", ErrorMessage = "The value must be numeric.")]
public string Value { get; set; }
}
public class OuterViewModel
{
public List<UnitsServiceViewModel> Units_Service { get; set; }
internal List<int> Units_Service_Parsed
{
get
{
if (Units_Service is null) return null;
List<int> value = new(Units_Service.Count);
foreach (UnitsServiceViewModel vm in Units_Service)
{
int.TryParse(vm.Value, out int i);
value.Add(i);
}
return value;
}
set
{
if (value is null)
{
Units_Service = null;
}
else
{
List<UnitsServiceViewModel> list = new(value.Count);
foreach (int i in value)
{
list.Add(new() { Value = i.ToString() });
}
Units_Service = list;
}
}
}
}
@for (int i = 0; i < Model.Units_Service.Count; i++)
{
<div class="row">
<div class="col-md-3">
@Html.LabelFor(model => model.Units_Service[i].Value, Model.Workload_Category_Name[i])
</div>
<div class="col-md-4">
@Html.TextBoxFor(model => model.Units_Service[i].Value, new { style = "width: 15%", MaskedTextBox = "9999", inputmode = "numeric" })
@Html.ValidationMessageFor(model => model.Units_Service[i].Value)
</div>
</div>
}
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Thanks Richard. Your answer works perfect 
|
|
|
|
|
Fokwa Divine wrote: "^[0-9]*$"
Note that this (and in the corrected code) allows for an empty string.
You probably want the following
^[0-9]+$
You might also want to check for limits. So is '0' a correct value? Is '1000000000'?
|
|
|
|
|
Thanks for your input jschell
Yes, I am checking for limit and '0' is a correct value per requirement
|
|
|
|
|
function to extract the nibbles from a given byte.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
