i used the below code to from one date to another date records

Question

0.00/5 (No votes)

See more:

C#

private void button1_Click(object sender, EventArgs e)
        {
            DataTable dt = new DataTable(); SqlDataAdapter sda = new SqlDataAdapter("Select * from patient where Date between '" + dateTimePicker1.Text + "' and '" + dateTimePicker2.Text + "'", myconnection);
sda.Fill(dt);
dataGridView1.DataSource = dt;

        }

can anyone help whats the problem when i am clicking to see from one date to another date records

thanks in advance

Posted 19-Sep-15 20:55pm

Muhammad Qasim Ludin

Updated 19-Sep-15 21:30pm

Wendelius

v2

Add a Solution

2 solutions

Solution 1

The main problem is that you concatenate the values directly to the SQL statement. This leaves you wide open to SQL injections and also causes problems since you're relying on implicit conversion from character data to datetime.

The cure is to use parameters. In other words your code should look something like

C#

DataTable dt = new DataTable(); 
SqlCommand sc = new SqlCommand();
sc.CommandText = "Select * from patient where Date between @date1 and @date2";
sc.Connection = myconnection;
sc.Parameters.AddWithValue("@date1", dateTimePicker1.Value);
sc.Parameters.AddWithValue("@date2", dateTimePicker2.Value);
SqlDataAdapter sda = new SqlDataAdapter();
sda.SelectCommand = sc;
sda.Fill(dt);
dataGridView1.DataSource = dt;

(Sorry for possible typos)

Also you should use using blocks to ensure proper disposal of commands, connections and so on.

I'd also recommend reading Properly executing database operations[^]

Posted 19-Sep-15 21:37pm

Wendelius

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-09-19T21:38:00

For starters, stop doing it like that! Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

C#

private void button1_Click(object sender, EventArgs e)
        {
        DataTable dt = new DataTable(); 
        SqlDataAdapter sda = new SqlDataAdapter("SELECT * FROM patient WHERE [Date] BETWEEN @ST AND @EN", myconnection);
        sda.SelectCommand.Parameters.AddWithValue("@ST", dateTimePicker1.Value);
        sda.SelectCommand.Parameters.AddWithValue("@EN", dateTimePicker2.Value);
        sda.Fill(dt);
        dataGridView1.DataSource = dt;
        }

The chances are that will solve your problem at the same time.

[edit]Typo: wrote "@ED" for "@EN" in the second parameter line.[/edit]