How to add exception to continue with the code in C#?

Question

1.44/5 (2 votes)

See more:

var path = @"C:\Downloads\cesu";
            var result = @"C:\Downloads\Meternames.txt";
            File.WriteAllText(result, string.Empty);
            foreach (var file in System.IO.Directory.GetFiles(path, "*.xml"))
            {
                Console.WriteLine(file);
                XDocument xdoc = XDocument.Load(file);/* Here an exception is being thrown at some file :System.Xml.XmlException: 'The 'EVENT' start tag on line 29 position 484324 does not match the end tag of 'D5'. Line 29, position 529011.'*/

                
                string uid = xdoc.Descendants("G1").First()?.Value;
                Console.WriteLine(uid);
                using (StreamWriter sw = File.AppendText(result))
                {
                    sw.WriteLine(uid);
                }

            }
        }

What I have tried:

I want to skip that file and continue with reading of all files. Please suggest/modify the code so that I can skip the files with error and continue reading rest of the files.
I am reading approx 40000 files.

Posted 24-Jun-21 22:51pm

Himansh jain

Updated 24-Jun-21 22:57pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2021-06-24T22:57:00

Just add a try ... catch block:

C#

foreach (string file in System.IO.Directory.GetFiles(path, "*.xml"))
    {
    Console.WriteLine(file);
    try
        {
        XDocument xdoc = XDocument.Load(file);
        string uid = xdoc.Descendants("G1").First()?.Value;
        Console.WriteLine(uid);
        using (StreamWriter sw = File.AppendText(result))
            {
            sw.WriteLine(uid);
            }
        }    
    catch (Exception e)
        {
        Console.WriteLine($"Unable to load \"{file}\"\n   {e.Message}");
        }
    }